From a1b37d1e8d1c1ec43d4abdba2f6441bae0bb98d8 Mon Sep 17 00:00:00 2001 From: Stephan Rauh <3045767+stephanrauh@users.noreply.github.com> Date: Sun, 6 Oct 2024 22:25:52 +0200 Subject: [PATCH] updated the changelog and the readme after accidentally publishing the new version with the wrong version number --- projects/ngx-extended-pdf-viewer/README.md | 6 ++---- projects/ngx-extended-pdf-viewer/changelog.md | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/projects/ngx-extended-pdf-viewer/README.md b/projects/ngx-extended-pdf-viewer/README.md index 7e953db00..3a286fabd 100644 --- a/projects/ngx-extended-pdf-viewer/README.md +++ b/projects/ngx-extended-pdf-viewer/README.md @@ -39,11 +39,9 @@ This library provides an embeddable PDF viewer component. It's different from ot Version 20.0.2 is a security fix. It solves CVE-2024-4367. I strongly recommend updating to the latest version of ngx-extended-pdf-viewer as soon as possible, or to version 20.0.2 as a minimum. Older versions contain a bug allowing malicious PDF files to run arbitrary code. Kudos go to GitHub users ScratchPDX and Deepak Shakya to tell me about it, so I could provide a hotfix during my vacations. -## Version 22.0: update to pdf.js 4.7 +## Version 21.4: improved search UI and update to pdf.js 4.6 / 4.7 -Version 22.0 updates to pdf.js 4.7. It offers the same functionality as version 21.4, but it's a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous - -## Version 21.4: improved search UI and update to pdf.js 4.6 +Version 21.4.5 updates to pdf.js 4.7. It offers the same functionality as version 21.4, but it's a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous. Unfortunately, I forgot to update the version number, so this version breaks semantic versioning. Addig insult to injury, npm does not allow me to revert publishing, so there's no way to fix this. The good news is that your application probably will still work, even if it uses the modified method. Version 21.4 updates to pdf.js 4.6. It also improved the search functionality: the find button is hidden if there's no text layer in the PDF document (or at least in the first 20 pages of the PDF document - this seems to be a decent compromise between accuracy and performance). If there's no find button or no text layer, CTRL+F doesn't open the find bar. diff --git a/projects/ngx-extended-pdf-viewer/changelog.md b/projects/ngx-extended-pdf-viewer/changelog.md index 5dd4cd7cf..be3fd53b2 100644 --- a/projects/ngx-extended-pdf-viewer/changelog.md +++ b/projects/ngx-extended-pdf-viewer/changelog.md @@ -599,4 +599,4 @@ - 21.4.2 #2571 if the PDF viewer is destroyed while it's still initializing, it inevitably runs into errors; I've added an additional check, so there's one error message less; updated the bleeding edge branch (it might still be broken due to many changes of pdf.js) - 21.4.3 caveat: this version accidentally broke the stable branch! Please update to version 21.4.4 instead. Intended changes: dependency updates; updated the bleeding edge branch - 21.4.4 repaired the stable branch -- 22.0.0-alpha.0 updated the bleeding edge branch to pdf.js 4.7.76; this is a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous +- 21.4.5 updated the bleeding edge branch to pdf.js 4.7.76; this is a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous