{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27085821,"defaultBranch":"master","name":"stellar-core","ownerLogin":"stellar","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-24T17:11:12.000Z","ownerAvatar":"https://github.com/avatars/u/7386716?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726087330.0","currentOid":""},"activityList":{"items":[{"before":"fbb53d8ad42dcc12a046c9be949d654821a24d38","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4431-64da5e97e97d7a8e92e42a0824009cf042800e19","pushedAt":"2024-09-11T20:42:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"64da5e97e97d7a8e92e42a0824009cf042800e19","after":"fbb53d8ad42dcc12a046c9be949d654821a24d38","ref":"refs/heads/master","pushedAt":"2024-09-11T20:42:08.000Z","pushType":"merge_queue_merge","commitsCount":10,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Switch read-only LedgerTxn to BucketList snapshots (#4431)\n\nResolves https://github.com/stellar/stellar-core/issues/4315 and\nhttps://github.com/stellar/stellar-core/issues/3800 This PR\nautomatically switches overlay/herder to using BucketListDB snapshots\ninstead of LedgerTxn.\n\nThis change introduces a single \"read-only ledger state snapshot\"\ninterface, which supports both SQL (via LedgerTxn) and BucketListDB\nsnapshots. A unified interface avoids invasive changes to the rest of\nthe codebase to support both snapshot types, and allows to have a\ncentralized validation flow for both overlay and apply time.\n\nA notable change is the removal of nested LegderTxn in validation paths,\nand using loadWithoutRecord instead in newer protocols. This creates a\nstronger invariant that validation flow is only meant to be accessing\nread-only version of the ledger, and prevents it from making\nmodifications by accident. Note that nested LedgerTxn is preserved for\nolder buggy versions of the protocol (making the code a bit uglier than\nI would have preferred, I'm open to ideas on simplifying/refactoring old\nprotocol logic out of the critical path).","shortMessageHtmlLink":"Switch read-only LedgerTxn to BucketList snapshots (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2469147282\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4431\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4431/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4431\">#4431</a>)"}},{"before":null,"after":"fbb53d8ad42dcc12a046c9be949d654821a24d38","ref":"refs/heads/gh-readonly-queue/master/pr-4431-64da5e97e97d7a8e92e42a0824009cf042800e19","pushedAt":"2024-09-11T19:26:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Switch read-only LedgerTxn to BucketList snapshots (#4431)\n\nResolves https://github.com/stellar/stellar-core/issues/4315 and\nhttps://github.com/stellar/stellar-core/issues/3800 This PR\nautomatically switches overlay/herder to using BucketListDB snapshots\ninstead of LedgerTxn.\n\nThis change introduces a single \"read-only ledger state snapshot\"\ninterface, which supports both SQL (via LedgerTxn) and BucketListDB\nsnapshots. A unified interface avoids invasive changes to the rest of\nthe codebase to support both snapshot types, and allows to have a\ncentralized validation flow for both overlay and apply time.\n\nA notable change is the removal of nested LegderTxn in validation paths,\nand using loadWithoutRecord instead in newer protocols. This creates a\nstronger invariant that validation flow is only meant to be accessing\nread-only version of the ledger, and prevents it from making\nmodifications by accident. Note that nested LedgerTxn is preserved for\nolder buggy versions of the protocol (making the code a bit uglier than\nI would have preferred, I'm open to ideas on simplifying/refactoring old\nprotocol logic out of the critical path).","shortMessageHtmlLink":"Switch read-only LedgerTxn to BucketList snapshots (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2469147282\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4431\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4431/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4431\">#4431</a>)"}},{"before":"d39a64c37a7f3b43bb62ff595ba1ada1d593afa6","after":"d95bf471d8a988274602d38f2d8693ea01722c1b","ref":"refs/heads/acceptance-test-pass","pushedAt":"2024-09-11T00:43:45.000Z","pushType":"push","commitsCount":18,"pusher":{"login":"stellar-jenkins","name":null,"path":"/stellar-jenkins","primaryAvatarUrl":"https://github.com/avatars/u/7843278?s=80&v=4"},"commit":{"message":"Windows fixes (#4449)\n\n(refreshed previous PR that was conflicting with other changes in\nmaster)\n\n@SirTyson -- I got a warning that `1UL << 36` is UB because the type is\n32 bits","shortMessageHtmlLink":"Windows fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2498102060\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4449\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4449/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4449\">#4449</a>)"}},{"before":"64da5e97e97d7a8e92e42a0824009cf042800e19","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4463-55bc7b44534593542f01069f64b3719bf3c815cc","pushedAt":"2024-09-10T23:08:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"55bc7b44534593542f01069f64b3719bf3c815cc","after":"64da5e97e97d7a8e92e42a0824009cf042800e19","ref":"refs/heads/master","pushedAt":"2024-09-10T23:08:42.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Fix exception-safety in callbacks from Rust to C++ (#4463)\n\nWe've been using cxx slightly wrong around callbacks from Rust to C++.\nThis isn't likely a problem as we only have two such callbacks and they\ncall into the C++ logging system which rarely if ever throws, but just\nto be on the safe side we should define these functions as returning\n`cxx::Result` not a plain Rust type. It turns out cxx puts a `noexcept`\nwrapper around all such callbacks to ensure they don't throw (and\nconfuse Rust ABIs) and by doing this it means any throw in the C++ side\nwould wind up causing the C++ runtime to call `std::terminate` (which is\nwhat it does when a `noexcept` function throws anyways).\n\nThe fix is very straightforward.","shortMessageHtmlLink":"Fix exception-safety in callbacks from Rust to C++ (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2517779790\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4463\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4463/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4463\">#4463</a>)"}},{"before":null,"after":"64da5e97e97d7a8e92e42a0824009cf042800e19","ref":"refs/heads/gh-readonly-queue/master/pr-4463-55bc7b44534593542f01069f64b3719bf3c815cc","pushedAt":"2024-09-10T21:53:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Fix exception-safety in callbacks from Rust to C++ (#4463)\n\nWe've been using cxx slightly wrong around callbacks from Rust to C++.\nThis isn't likely a problem as we only have two such callbacks and they\ncall into the C++ logging system which rarely if ever throws, but just\nto be on the safe side we should define these functions as returning\n`cxx::Result` not a plain Rust type. It turns out cxx puts a `noexcept`\nwrapper around all such callbacks to ensure they don't throw (and\nconfuse Rust ABIs) and by doing this it means any throw in the C++ side\nwould wind up causing the C++ runtime to call `std::terminate` (which is\nwhat it does when a `noexcept` function throws anyways).\n\nThe fix is very straightforward.","shortMessageHtmlLink":"Fix exception-safety in callbacks from Rust to C++ (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2517779790\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4463\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4463/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4463\">#4463</a>)"}},{"before":"55bc7b44534593542f01069f64b3719bf3c815cc","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4455-dacd02c1da2982e6a1b232c9607d3d743d4315f9","pushedAt":"2024-09-10T21:09:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"dacd02c1da2982e6a1b232c9607d3d743d4315f9","after":"55bc7b44534593542f01069f64b3719bf3c815cc","ref":"refs/heads/master","pushedAt":"2024-09-10T21:09:44.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Switch Soroban tests to always use closeLedger to apply txs. (#4455)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4451\n\nSwitch Soroban tests to always use closeLedger to apply txs.\n\nThis is a necessary change for the BucketListDB support as it doesn't\nmaterialize changes on LTX commit. I've also changed a single test\n('basic contract invocation') to only use in-memory LTX in order to\ncover lower-level logic.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Switch Soroban tests to always use closeLedger to apply txs. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2506299176\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4455/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4455\">#4455</a>)"}},{"before":null,"after":"55bc7b44534593542f01069f64b3719bf3c815cc","ref":"refs/heads/gh-readonly-queue/master/pr-4455-dacd02c1da2982e6a1b232c9607d3d743d4315f9","pushedAt":"2024-09-10T19:54:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Switch Soroban tests to always use closeLedger to apply txs. (#4455)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4451\n\nSwitch Soroban tests to always use closeLedger to apply txs.\n\nThis is a necessary change for the BucketListDB support as it doesn't\nmaterialize changes on LTX commit. I've also changed a single test\n('basic contract invocation') to only use in-memory LTX in order to\ncover lower-level logic.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Switch Soroban tests to always use closeLedger to apply txs. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2506299176\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4455/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4455\">#4455</a>)"}},{"before":"0f58f745dcadc5d01b31eb3b74020009963d9e53","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4455-dacd02c1da2982e6a1b232c9607d3d743d4315f9","pushedAt":"2024-09-10T18:37:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":null,"after":"0f58f745dcadc5d01b31eb3b74020009963d9e53","ref":"refs/heads/gh-readonly-queue/master/pr-4455-dacd02c1da2982e6a1b232c9607d3d743d4315f9","pushedAt":"2024-09-10T18:27:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Switch Soroban tests to always use closeLedger to apply txs. (#4455)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4451\n\nSwitch Soroban tests to always use closeLedger to apply txs.\n\nThis is a necessary change for the BucketListDB support as it doesn't\nmaterialize changes on LTX commit. I've also changed a single test\n('basic contract invocation') to only use in-memory LTX in order to\ncover lower-level logic.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Switch Soroban tests to always use closeLedger to apply txs. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2506299176\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4455/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4455\">#4455</a>)"}},{"before":"dacd02c1da2982e6a1b232c9607d3d743d4315f9","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4452-d95bf471d8a988274602d38f2d8693ea01722c1b","pushedAt":"2024-09-10T00:24:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"d95bf471d8a988274602d38f2d8693ea01722c1b","after":"dacd02c1da2982e6a1b232c9607d3d743d4315f9","ref":"refs/heads/master","pushedAt":"2024-09-10T00:24:57.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"initial commit: Jupyter notebook to help estimate network settings (#4452)\n\nThis PR adds a notebook with rudimentary support for estimating disk\niops/bandwidth and network utilization.\n\nThis is just a starting point, and is probably quite off (impact of\nbucketlist merges, eviction and archival is not included), but should\nstill allow to reason at the right order of magnitude when making\nchanges.\n\nOver time, this can be extended as to better help estimate limits (both\ntx level and ledger level) used in Soroban and elsewhere, especially\nlimits that should \"never be reduced\" in the future.\n\nThis version outputs the following:\n```\nledger_LE_reads:  50000\nledger_bytes_read:  28775000\nledger_LE_writes:  25000\nledger_bytes_write:  3175000\nledger_classic_LE_reads:  500000\nledger_classic_bytes_read:  291000000\nledger_classic_LE_writes:  250000\nledger_classic_bytes_write:  35000000\nledger_soroban_LE_reads:  800000\nledger_soroban_bytes_read:  1474560000.0\nledger_soroban_LE_writes:  250000\nledger_soroban_bytes_write:  665600000.0\n\n...\n\nflooding bytes (per connection):  147500000.0\nTxSet bytes:  59000000\nNetwork bps (GBit/s):  3.1663477420806885\n\n...\n\nmax iops:  1963575.4285714286\nmax read Mbps:  2463.800726209368\nmax write Mbps:  2684.6885681152344\nmax disk bandwidth Mbps:  2703.9018592834473\n\n```\n\nwhich is in line with our expectation that NVMe drives will probably be\nneeded as tps increases","shortMessageHtmlLink":"initial commit: Jupyter notebook to help estimate network settings (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2504056191\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4452\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4452/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4452\">#…</a>"}},{"before":null,"after":"dacd02c1da2982e6a1b232c9607d3d743d4315f9","ref":"refs/heads/gh-readonly-queue/master/pr-4452-d95bf471d8a988274602d38f2d8693ea01722c1b","pushedAt":"2024-09-09T23:49:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"initial commit: Jupyter notebook to help estimate network settings (#4452)\n\nThis PR adds a notebook with rudimentary support for estimating disk\niops/bandwidth and network utilization.\n\nThis is just a starting point, and is probably quite off (impact of\nbucketlist merges, eviction and archival is not included), but should\nstill allow to reason at the right order of magnitude when making\nchanges.\n\nOver time, this can be extended as to better help estimate limits (both\ntx level and ledger level) used in Soroban and elsewhere, especially\nlimits that should \"never be reduced\" in the future.\n\nThis version outputs the following:\n```\nledger_LE_reads:  50000\nledger_bytes_read:  28775000\nledger_LE_writes:  25000\nledger_bytes_write:  3175000\nledger_classic_LE_reads:  500000\nledger_classic_bytes_read:  291000000\nledger_classic_LE_writes:  250000\nledger_classic_bytes_write:  35000000\nledger_soroban_LE_reads:  800000\nledger_soroban_bytes_read:  1474560000.0\nledger_soroban_LE_writes:  250000\nledger_soroban_bytes_write:  665600000.0\n\n...\n\nflooding bytes (per connection):  147500000.0\nTxSet bytes:  59000000\nNetwork bps (GBit/s):  3.1663477420806885\n\n...\n\nmax iops:  1963575.4285714286\nmax read Mbps:  2463.800726209368\nmax write Mbps:  2684.6885681152344\nmax disk bandwidth Mbps:  2703.9018592834473\n\n```\n\nwhich is in line with our expectation that NVMe drives will probably be\nneeded as tps increases","shortMessageHtmlLink":"initial commit: Jupyter notebook to help estimate network settings (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2504056191\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4452\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4452/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4452\">#…</a>"}},{"before":"d95bf471d8a988274602d38f2d8693ea01722c1b","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4449-e02d75aad5fc5c16f81e233d0315b030937a88d8","pushedAt":"2024-09-06T19:43:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"e02d75aad5fc5c16f81e233d0315b030937a88d8","after":"d95bf471d8a988274602d38f2d8693ea01722c1b","ref":"refs/heads/master","pushedAt":"2024-09-06T19:43:04.000Z","pushType":"merge_queue_merge","commitsCount":4,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Windows fixes (#4449)\n\n(refreshed previous PR that was conflicting with other changes in\nmaster)\n\n@SirTyson -- I got a warning that `1UL << 36` is UB because the type is\n32 bits","shortMessageHtmlLink":"Windows fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2498102060\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4449\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4449/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4449\">#4449</a>)"}},{"before":null,"after":"d95bf471d8a988274602d38f2d8693ea01722c1b","ref":"refs/heads/gh-readonly-queue/master/pr-4449-e02d75aad5fc5c16f81e233d0315b030937a88d8","pushedAt":"2024-09-06T18:52:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Windows fixes (#4449)\n\n(refreshed previous PR that was conflicting with other changes in\nmaster)\n\n@SirTyson -- I got a warning that `1UL << 36` is UB because the type is\n32 bits","shortMessageHtmlLink":"Windows fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2498102060\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4449\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4449/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4449\">#4449</a>)"}},{"before":"e02d75aad5fc5c16f81e233d0315b030937a88d8","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4458-6cd475348c6a8372adea257d600efe9599ed8623","pushedAt":"2024-09-06T18:23:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"6cd475348c6a8372adea257d600efe9599ed8623","after":"e02d75aad5fc5c16f81e233d0315b030937a88d8","ref":"refs/heads/master","pushedAt":"2024-09-06T18:23:15.000Z","pushType":"merge_queue_merge","commitsCount":3,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"bugfix: guard access to mNoOutboundCapacity (#4458)\n\nFix issue discovered by static analysis (data race on\n`mNoOutboundCapacity`). This variable is used to trigger recovery in\ncase flow control gets stuck. In practice, this triggers very rarely (if\nat all), which is probably why we did not catch this before.","shortMessageHtmlLink":"bugfix: guard access to mNoOutboundCapacity (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2508317266\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4458\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4458/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4458\">#4458</a>)"}},{"before":null,"after":"e02d75aad5fc5c16f81e233d0315b030937a88d8","ref":"refs/heads/gh-readonly-queue/master/pr-4458-6cd475348c6a8372adea257d600efe9599ed8623","pushedAt":"2024-09-06T17:32:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"bugfix: guard access to mNoOutboundCapacity (#4458)\n\nFix issue discovered by static analysis (data race on\n`mNoOutboundCapacity`). This variable is used to trigger recovery in\ncase flow control gets stuck. In practice, this triggers very rarely (if\nat all), which is probably why we did not catch this before.","shortMessageHtmlLink":"bugfix: guard access to mNoOutboundCapacity (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2508317266\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4458\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4458/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4458\">#4458</a>)"}},{"before":"6cd475348c6a8372adea257d600efe9599ed8623","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4420-c8d2bb27040fd87a65dd20d9b7f8670c497aa981","pushedAt":"2024-09-03T21:27:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"c8d2bb27040fd87a65dd20d9b7f8670c497aa981","after":"6cd475348c6a8372adea257d600efe9599ed8623","ref":"refs/heads/master","pushedAt":"2024-09-03T21:27:45.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"docs: add overlay intro and fix typos (#4420)\n\nResolves https://github.com/stellar/stellar-core/issues/2828","shortMessageHtmlLink":"docs: add overlay intro and fix typos (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2451471577\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4420\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4420/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4420\">#4420</a>)"}},{"before":null,"after":"6cd475348c6a8372adea257d600efe9599ed8623","ref":"refs/heads/gh-readonly-queue/master/pr-4420-c8d2bb27040fd87a65dd20d9b7f8670c497aa981","pushedAt":"2024-09-03T20:06:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"docs: add overlay intro and fix typos (#4420)\n\nResolves https://github.com/stellar/stellar-core/issues/2828","shortMessageHtmlLink":"docs: add overlay intro and fix typos (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2451471577\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4420\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4420/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4420\">#4420</a>)"}},{"before":"c8d2bb27040fd87a65dd20d9b7f8670c497aa981","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4442-62313d8b1113d219417ca50f9ad09716ad12c69f","pushedAt":"2024-08-31T00:01:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"62313d8b1113d219417ca50f9ad09716ad12c69f","after":"c8d2bb27040fd87a65dd20d9b7f8670c497aa981","ref":"refs/heads/master","pushedAt":"2024-08-31T00:01:42.000Z","pushType":"merge_queue_merge","commitsCount":3,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Add support for Soroban constructors (CAP-58) (#4442)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4437,\nhttps://github.com/stellar/rs-soroban-env/issues/1438\n\nThis doesn't have much logic beyond env/XDR bumps and basic test\ncoverage. However, the check for not supporting the new XDR in the old\nprotocol is done in generic fashion via Soroban env XDR roundtrip.\n\nThis also includes a few test fixes to unblock CI.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Add support for Soroban constructors (CAP-58) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2487932898\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4442\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4442/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4442\">#4442</a>)"}},{"before":null,"after":"c8d2bb27040fd87a65dd20d9b7f8670c497aa981","ref":"refs/heads/gh-readonly-queue/master/pr-4442-62313d8b1113d219417ca50f9ad09716ad12c69f","pushedAt":"2024-08-30T22:48:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Add support for Soroban constructors (CAP-58) (#4442)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4437,\nhttps://github.com/stellar/rs-soroban-env/issues/1438\n\nThis doesn't have much logic beyond env/XDR bumps and basic test\ncoverage. However, the check for not supporting the new XDR in the old\nprotocol is done in generic fashion via Soroban env XDR roundtrip.\n\nThis also includes a few test fixes to unblock CI.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Add support for Soroban constructors (CAP-58) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2487932898\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4442\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4442/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4442\">#4442</a>)"}},{"before":"62313d8b1113d219417ca50f9ad09716ad12c69f","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4413-052c40bafe762969de36bcb3b488d013cdb64dce","pushedAt":"2024-08-30T02:14:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"}},{"before":"052c40bafe762969de36bcb3b488d013cdb64dce","after":"62313d8b1113d219417ca50f9ad09716ad12c69f","ref":"refs/heads/master","pushedAt":"2024-08-30T02:14:34.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Soroban upgrades for simulation tests (#4413)","shortMessageHtmlLink":"Soroban upgrades for simulation tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2445822345\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4413\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4413/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4413\">#4413</a>)"}},{"before":null,"after":"62313d8b1113d219417ca50f9ad09716ad12c69f","ref":"refs/heads/gh-readonly-queue/master/pr-4413-052c40bafe762969de36bcb3b488d013cdb64dce","pushedAt":"2024-08-30T01:09:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://github.com/avatars/u/9919?s=80&v=4"},"commit":{"message":"Soroban upgrades for simulation tests (#4413)","shortMessageHtmlLink":"Soroban upgrades for simulation tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2445822345\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4413\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4413/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4413\">#4413</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEs6bUXwA","startCursor":null,"endCursor":null}},"title":"Activity · stellar/stellar-core"}