Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix stache consistency issues with console commands #10574

Open
wants to merge 5 commits into
base: 5.x
Choose a base branch
from

Conversation

kingsven
Copy link
Contributor

@kingsven kingsven commented Aug 6, 2024

Fixes #10514

@simonworkhouse
Copy link
Contributor

One issue with this fix is that it currently does not handle shortened versions of console commands such as php artisan tin. However; I would argue that this is an issue with Laravel's handling of App::runningConsoleCommand(...) which would require a separate PR submitted to laravel/framework.

$ php artisan tin
Psy Shell v0.12.4 (PHP 8.2.18 — cli) by Justin Hileman
> Statamic\Statamic::isWorker()
= false

$ php artisan tinker
Psy Shell v0.12.4 (PHP 8.2.18 — cli) by Justin Hileman
> Statamic\Statamic::isWorker()
= true
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Statamic::isWorker() check may need to also apply to console commands
2 participants