Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature reload-on-delete implemented, test cases enhanced #695

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

deschmih
Copy link
Contributor

This PR contains the feature "reload-on-delete" as enhancement refering to issue #622.
For beeing backwards compatible an additional flag reload-on-delete at commandline is implemented for using this feature. This corresponding flag reloadOnDelete is also now part in the values.yaml of the helm chart. Testcases are enhaced.

Copy link

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-2260d728\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-2260d728

@deschmih
Copy link
Contributor Author

@MuneebAijaz reviewers are welcome ;-) Test cases are enhanced.

@deschmih
Copy link
Contributor Author

deschmih commented Jul 3, 2024

@MuneebAijaz - Are you the right person to review this pull request in a timely manner ?

@MuneebAijaz
Copy link
Contributor

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

@bartselect
Copy link

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

I believe in you brotha

@MuneebAijaz
Copy link
Contributor

hi @deschmih PR looks fine. can you resolve conflicts and pls separate out docs changes in another PR? There's is an ongoing issue about docs and code workflows running together causing issues.

Copy link

github-actions bot commented Jul 8, 2024

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cbf501fc\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cbf501fc

Copy link

github-actions bot commented Jul 8, 2024

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-074a42d8\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-074a42d8

@deschmih
Copy link
Contributor Author

deschmih commented Jul 8, 2024

@MuneebAijaz All conflicts resolved. Removed changes to readme.md (doc). After this PR is approved, a separate PR will be created to modify readme.md.

@MuneebAijaz
Copy link
Contributor

@deschmih
Copy link
Contributor Author

deschmih commented Jul 8, 2024

@MuneebAijaz now it should be fixed

Copy link

github-actions bot commented Jul 8, 2024

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cda9fa9b\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cda9fa9b

@MuneebAijaz
Copy link
Contributor

thank you @deschmih. You are the best ❤️

@MuneebAijaz MuneebAijaz merged commit b6894f6 into stakater:master Jul 8, 2024
5 checks passed
@bartselect
Copy link

Great job! @deschmih thanks for you input here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants