From a762d7744cfa019edd09121ebedfffb669856264 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 2 Feb 2023 12:15:57 +0100 Subject: [PATCH 1/4] Shorten the CSI registration path (fixes #229) --- deploy/helm/secret-operator/templates/daemonset.yaml | 2 +- deploy/manifests/daemonset.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/helm/secret-operator/templates/daemonset.yaml b/deploy/helm/secret-operator/templates/daemonset.yaml index da4d9b41..d0568a66 100644 --- a/deploy/helm/secret-operator/templates/daemonset.yaml +++ b/deploy/helm/secret-operator/templates/daemonset.yaml @@ -69,7 +69,7 @@ spec: volumes: - name: registration-sock hostPath: - path: /var/lib/kubelet/plugins_registry/secrets.stackable.tech-reg.sock + path: /var/lib/kubelet/plugins_registry - name: csi hostPath: path: /var/lib/kubelet/plugins/secrets.stackable.tech/ diff --git a/deploy/manifests/daemonset.yaml b/deploy/manifests/daemonset.yaml index 7026417c..88429cc5 100644 --- a/deploy/manifests/daemonset.yaml +++ b/deploy/manifests/daemonset.yaml @@ -64,7 +64,7 @@ spec: volumes: - name: registration-sock hostPath: - path: /var/lib/kubelet/plugins_registry/secrets.stackable.tech-reg.sock + path: /var/lib/kubelet/plugins_registry - name: csi hostPath: path: /var/lib/kubelet/plugins/secrets.stackable.tech/ From 4cc0403c904e9bf356cdb59b0797d2c39b4d250c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 2 Feb 2023 12:28:22 +0100 Subject: [PATCH 2/4] Comment on why this is still safe --- deploy/helm/secret-operator/templates/daemonset.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/deploy/helm/secret-operator/templates/daemonset.yaml b/deploy/helm/secret-operator/templates/daemonset.yaml index d0568a66..3a750c31 100644 --- a/deploy/helm/secret-operator/templates/daemonset.yaml +++ b/deploy/helm/secret-operator/templates/daemonset.yaml @@ -69,6 +69,7 @@ spec: volumes: - name: registration-sock hostPath: + # node-driver-registrar appends a driver-unique filename to this path to avoid conflicts path: /var/lib/kubelet/plugins_registry - name: csi hostPath: From ac7ea1ca287da2b0a681a01411ed18f570d768f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 2 Feb 2023 12:31:49 +0100 Subject: [PATCH 3/4] CHANGELOG --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a2cd74f4..7fa382c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,8 +7,13 @@ All notable changes to this project will be documented in this file. ### Changed - operator-rs: 0.25.0 -> 0.27.1 ([#212]). +- Shortened the registration socket path for Microk8s compatibility ([#231]). + - After upgrading you will need to + `rmdir /var/lib/kubelet/plugins_registry/secrets.stackable.tech-reg.sock` manually. + This applies to *all* users, not just Microk8s. [#212]: https://github.com/stackabletech/secret-operator/pull/212 +[#231]: https://github.com/stackabletech/secret-operator/pull/231 ## [0.6.0] - 2022-11-07 From 29bc26146595397ef76970232e47c554d56e0608 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 2 Feb 2023 12:32:17 +0100 Subject: [PATCH 4/4] Add link to issue --- deploy/helm/secret-operator/templates/daemonset.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/deploy/helm/secret-operator/templates/daemonset.yaml b/deploy/helm/secret-operator/templates/daemonset.yaml index 3a750c31..1cdac5fc 100644 --- a/deploy/helm/secret-operator/templates/daemonset.yaml +++ b/deploy/helm/secret-operator/templates/daemonset.yaml @@ -70,6 +70,7 @@ spec: - name: registration-sock hostPath: # node-driver-registrar appends a driver-unique filename to this path to avoid conflicts + # see https://github.com/stackabletech/secret-operator/issues/229 for why this path should not be too long path: /var/lib/kubelet/plugins_registry - name: csi hostPath: