diff --git a/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack.java b/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack.java index af390f170b2..f60119e548a 100644 --- a/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack.java +++ b/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalStack.java @@ -84,7 +84,6 @@ public void onSuccess(String childId) { public void dismissAllModals(ViewController root, Options mergeOptions, CommandListener listener) { if (modals.isEmpty()) { - listener.onSuccess(root.getId()); return; } String topModalId = peek().getId(); diff --git a/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalStackTest.java b/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalStackTest.java index 00d20716232..543bf930eb7 100644 --- a/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalStackTest.java +++ b/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/modal/ModalStackTest.java @@ -173,13 +173,6 @@ public void onSuccess(String childId) { verifyZeroInteractions(listener); } - @Test - public void dismissAllModals_resolveSuccessfullyIfEmpty() { - CommandListener spy = spy(new CommandListenerAdapter()); - uut.dismissAllModals(root, Options.EMPTY, spy); - verify(spy, times(1)).onSuccess(root.getId()); - } - @Test public void dismissAllModals_optionsAreMergedOnTopModal() { uut.showModal(modal1, root, new CommandListenerAdapter()); diff --git a/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/navigator/NavigatorTest.java b/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/navigator/NavigatorTest.java index 5fe3fae2c76..a9324ff2b8b 100644 --- a/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/navigator/NavigatorTest.java +++ b/lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/navigator/NavigatorTest.java @@ -596,7 +596,6 @@ public void dismissModal_rejectIfRootIsNotSetAndSingleModalIsDisplayed() { public void dismissAllModals_onViewAppearedInvokedOnRoot() { disablePushAnimation(child2); disableShowModalAnimation(child1); - uut.setRoot(child3, new CommandListenerAdapter(), reactInstanceManager); uut.dismissAllModals(Options.EMPTY, new CommandListenerAdapter()); verify(parentVisibilityListener, times(0)).onViewAppeared(parentController.getView());