Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete "tmp" directory after successful gem installation. #970

Closed
flavorjones opened this issue Sep 12, 2013 · 7 comments
Closed

Delete "tmp" directory after successful gem installation. #970

flavorjones opened this issue Sep 12, 2013 · 7 comments

Comments

@flavorjones
Copy link
Member

See this StackOverflow question for the use case around deleting the tmp directory in Nokogiri 1.6.0+.

@knu
Copy link
Member

knu commented Sep 13, 2013

Please review the static_clean branch.
https://github.com/sparklemotion/nokogiri/tree/static_clean

@virgilm
Copy link

virgilm commented Oct 11, 2013

Any plans on integrating this patch?

@knu
Copy link
Member

knu commented Oct 12, 2013

@virgilm I don't know. I see only few people showed an interest in it. I need a real test report and a review before it can be merged.

@benlangfeld
Copy link
Contributor

@knu How do we use your patch? It looks like it's not set as the default behaviour and the --clean option needs passing, but where? I feel strongly that this should be the default behaviour :)

@knu
Copy link
Member

knu commented Oct 12, 2013

It is enabled by default.

@knu
Copy link
Member

knu commented Oct 21, 2013

Looks like @flavorjones has been busy, so I'll take this.

@knu
Copy link
Member

knu commented Oct 21, 2013

See #952.

@knu knu closed this as completed Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants