JRuby 1.7 test failure (encoding)

[flavorjones]

  1) Failure:
test_serialize_encoding_html(Nokogiri::XML::TestNodeEncoding) [/home/miked/code/oss/nokogiri/test/xml/test_node_encoding.rb:28]:
--- expected
+++ actual
@@ -13,9 +13,9 @@
 @import url(2ch_top.css);
 </style>
 <script>
-&lt;!--
+&amp;lt;!--
 function fcs(){document.f.STR.focus();}
---&gt;
+--&amp;gt;
 </script>
 </head>

@@ -48,4 +48,4 @@

 <input name=\"ENCODING\" type=\"hidden\" value=\"SJIS\">
 <input name=\"COUNT\" type=\"hidden\" value=\"50\">
-<div class=\"caption\">\x{967B}\x{95B6}\x{8C9F}\x{8DF5}\x{82E2}\x{8C9F}\x{8DF5}\x{90DD}\x{92E8}\x{82CD}<a href=\"http://find.2ch.net/moritapo/notlogin.php\">\x{838D}\x{834F}\x{8343}\x{8393}</a><a href=\"http://find.2ch.net/moritapo/welcome/\">"
+<div class=\"caption\">\x{967B}\x{95B6}\x{8C9F}\x{8DF5}\x{82E2}\x{8C9F}\x{8DF5}\x{90DD}\x{92E8}\x{82CD}<a href=\"http://find.2ch.net/moritapo/notlogin.php\">\x{838D}\x{834F}\x{8343}\x{8393}</a><a href=\"http://find.2ch.net/moritapo/welcome/\"></a></div></form></div></div></div></div></body></html>"


1213 tests, 3533 assertions, 1 failures, 0 errors, 11 skips

[jvshahid]

Yeah, it's the last failure we have on JRuby, if it wasn't for this failure we'd have been green on all JRuby versions months ago. I tried to fix it a couple of times, but still can't figure it out. I'll take another shot at it sometime this week and may be kill other HTML related bugs.

[tychobrailleur]

@jvshahid I don't know if this helps, I also had a look a while back, and it all came down to nekohtml: it converts the comments in the script tag (see also this), and the only option I could find to avoid that was to strip the comment altogether; the other difference, as far as I remember, conflicts with other tests: if tag-balancing is disabled, it breaks other tests.

So I think first difference is a neko bug, the second one not so sure.

[benlangfeld]

Someone buy that man a beer!