Replacing a Node from another document will crash on exit

[ration]

If you replace a node from another document, there is a crash on exit. A Node is probably referenced from both documents and tried to delete twice.

Example:

!/usr/bin/env ruby

require 'nokogiri'

xml1 = "

Original caption " xml2 = " Replacement caption " doc1 = Nokogiri::XML(xml1) doc2 = Nokogiri::XML(xml2) caption1 = doc1.xpath("//caption")[0] caption2 = doc2.xpath("//caption")[0] caption1.replace(caption2)

---

[flavorjones]

I believe what ration meant to say was:

#!/usr/bin/env ruby

require 'nokogiri'

xml1 = "<test>
  <caption>Original caption</caption>
</test>"
xml2 = "<test>
  <caption>Replacement caption</caption>
</test>"
doc1 = Nokogiri::XML(xml1)
doc2 = Nokogiri::XML(xml2)
caption1 = doc1.xpath("//caption")[0]
caption2 = doc2.xpath("//caption")[0]
caption1.replace(caption2)

[flavorjones]

Node#replace reimplemented using reparent_node_with. Fixed by ebd4483

[ration]

Ah yes, I didn't notice that the markdown broke the tags..

With this fix, doc2 will not contain the caption element. Is this the preferred behavior?
Personally I would assume the node is copied there, and something like "move" would actually move it.

[flavorjones]

yes, this is the preferred behavior. if you want to copy the node, copy it:
caption1.replace(caption2.dup)

[ration]

Ok, thanks for the fix!

Moving was actually what I wanted, so this is perfect. I might not be the only one who doesn't automatically see this behavior, so maybe the documentation for replace deserves a comment about this side effect for the originating doc.