Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically invalidate Station Desktop Sentry tokens #124

Open
2 tasks
Tracked by #121
juliangruber opened this issue Jul 16, 2024 · 3 comments
Open
2 tasks
Tracked by #121

Automatically invalidate Station Desktop Sentry tokens #124

juliangruber opened this issue Jul 16, 2024 · 3 comments
Assignees

Comments

@juliangruber
Copy link
Member

juliangruber commented Jul 16, 2024

  • Give each Station Desktop release a new Sentry tokens
  • Create a GitHub action that periodically checks if there's a token that's too old (>3 days) and then invalidate it

Motivation: Errors from outdated Station Desktop releases are flooding Sentry, and especially if already fixed, aren't actionable.

@juliangruber
Copy link
Member Author

I don't know if I will get to this one, @bajtos do you care about it more?

@patrickwoodhead patrickwoodhead mentioned this issue Jul 31, 2024
36 tasks
@bajtos
Copy link
Contributor

bajtos commented Aug 1, 2024

do you care about it more?

Not really.

I configured an ingestion rate limit based on Sentry tokens. When an older Desktop release floods Sentry with errors that have been fixed in a newer release, this rate limiter will drop most of those errors, and our quotas will not be affected.

@juliangruber
Copy link
Member Author

cool, removed from the already too big list of stretch goals then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants