Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't remove scope from request #96

Closed
mbrinkl opened this issue Jun 4, 2023 · 4 comments · Fixed by #101
Closed

can't remove scope from request #96

mbrinkl opened this issue Jun 4, 2023 · 4 comments · Fixed by #101

Comments

@mbrinkl
Copy link

mbrinkl commented Jun 4, 2023

Any reason scope cannot be removed from request? If undefined in config, it defaults to empty string.

@sebastianvitterso
Copy link
Collaborator

Is there any reason why you don't want this scope as part of the request? Feel free to elaborate your needs a bit more, and we'll look into it!

@mbrinkl
Copy link
Author

mbrinkl commented Jun 5, 2023

For my purposes, I later realized i could send scope as 'read write' and have same result as sending no scope. So this doesn't matter as much for me anymore.

I did find another similar issue on another oauth repo though, up to you what you want to do. mulesoft-labs/js-client-oauth2#98

@soofstad
Copy link
Owner

soofstad commented Jun 5, 2023

I agree that this should be considered a bug. For most servers the current behaviour does not cause any issues, but I see no reason why we shouldn't adhere to the spec on this.
Will you look into a fix @sebastianvitterso ? If not I can have a look in a few weeks time. Also, for some badly implemented servers, empty string should be considered a valid value that will be sent from client.

@jwill490
Copy link

@soofstad in my case, I'm accessing a Forgerock auth server that throws a 400 error when "scope" is in the request for the auth token. Is there anyway to disable the scope parameter for only the auth token request, while leaving it in the auth code request?

I imagine this is an edge case, but please let me know if you have any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants