From cd2dbe9c955564c4ee7fc745f2ab5898c8c7823d Mon Sep 17 00:00:00 2001 From: Kacper Kafara Date: Mon, 17 Jun 2024 15:26:06 +0200 Subject: [PATCH] chore(Android): fix lint warning of CustomToolbar component (#2176) ## Description Just noticed while working on #2169 that we got a warning in CustomToolbar. Edit: followed review suggestions and suppressed lints for all our view, where this was requried. ## Changes Suppressed lint on missing constructors. We're safe to miss these there, as this view is constructed only programatically (we do not inflate any of our views). ## Test code and steps to reproduce N/A ## Checklist - [ ] Ensured that CI passes --- .../src/main/java/com/swmansion/rnscreens/CustomSearchView.kt | 2 ++ android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt | 2 ++ android/src/main/java/com/swmansion/rnscreens/Screen.kt | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt b/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt index 28bd4ae97..89f7c7c7b 100644 --- a/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt +++ b/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt @@ -1,10 +1,12 @@ package com.swmansion.rnscreens +import android.annotation.SuppressLint import android.content.Context import androidx.activity.OnBackPressedCallback import androidx.appcompat.widget.SearchView import androidx.fragment.app.Fragment +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. class CustomSearchView(context: Context, fragment: Fragment) : SearchView(context) { /* CustomSearchView uses some variables from SearchView. They are listed below with links to documentation diff --git a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt index 3bc36355a..c77407839 100644 --- a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt +++ b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt @@ -1,7 +1,9 @@ package com.swmansion.rnscreens +import android.annotation.SuppressLint import android.content.Context import androidx.appcompat.widget.Toolbar // This class is used to store config closer to search bar +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. open class CustomToolbar(context: Context, val config: ScreenStackHeaderConfig) : Toolbar(context) diff --git a/android/src/main/java/com/swmansion/rnscreens/Screen.kt b/android/src/main/java/com/swmansion/rnscreens/Screen.kt index 1856eed10..4eacaf0e4 100644 --- a/android/src/main/java/com/swmansion/rnscreens/Screen.kt +++ b/android/src/main/java/com/swmansion/rnscreens/Screen.kt @@ -18,7 +18,7 @@ import com.facebook.react.uimanager.UIManagerHelper import com.facebook.react.uimanager.UIManagerModule import com.swmansion.rnscreens.events.HeaderHeightChangeEvent -@SuppressLint("ViewConstructor") +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. class Screen(context: ReactContext?) : FabricEnabledViewGroup(context) { val fragment: Fragment? get() = fragmentWrapper?.fragment