From 0076526ceb8765df821558f045dd7c89466b5d60 Mon Sep 17 00:00:00 2001 From: Ozan Gunalp Date: Tue, 2 Jul 2024 13:58:53 +0200 Subject: [PATCH 1/2] Disable retries for lazy producer test --- .../reactive/messaging/amqp/TracingAmqpToAppToAmqpTest.java | 1 - .../reactive/messaging/kafka/client/LazyInitializedTest.java | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/smallrye-reactive-messaging-amqp/src/test/java/io/smallrye/reactive/messaging/amqp/TracingAmqpToAppToAmqpTest.java b/smallrye-reactive-messaging-amqp/src/test/java/io/smallrye/reactive/messaging/amqp/TracingAmqpToAppToAmqpTest.java index 78406c965..e54a4ec41 100644 --- a/smallrye-reactive-messaging-amqp/src/test/java/io/smallrye/reactive/messaging/amqp/TracingAmqpToAppToAmqpTest.java +++ b/smallrye-reactive-messaging-amqp/src/test/java/io/smallrye/reactive/messaging/amqp/TracingAmqpToAppToAmqpTest.java @@ -9,7 +9,6 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.awaitility.Awaitility.await; import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertNull; import java.util.List; import java.util.concurrent.CopyOnWriteArrayList; diff --git a/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/client/LazyInitializedTest.java b/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/client/LazyInitializedTest.java index 88879f62b..33378cfcd 100644 --- a/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/client/LazyInitializedTest.java +++ b/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/client/LazyInitializedTest.java @@ -44,6 +44,7 @@ void testLazyInitializedProducer() { Map props = new HashMap<>(); props.put("tracing-enabled", false); props.put("lazy-client", true); + props.put("retries", 0L); props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "invalid-bootstrap-servers"); props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, IntegerSerializer.class.getName()); props.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, StringSerializer.class.getName()); From 228349a1110d3bc6a86b98184140587933d664a4 Mon Sep 17 00:00:00 2001 From: Ozan Gunalp Date: Wed, 3 Jul 2024 09:30:04 +0200 Subject: [PATCH 2/2] Fix flaky KafkaRequestReplyTest#testReplyOffsetResetEarliest --- .../messaging/kafka/reply/KafkaRequestReplyTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/reply/KafkaRequestReplyTest.java b/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/reply/KafkaRequestReplyTest.java index 196b6c04a..209b033b6 100644 --- a/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/reply/KafkaRequestReplyTest.java +++ b/smallrye-reactive-messaging-kafka/src/test/java/io/smallrye/reactive/messaging/kafka/reply/KafkaRequestReplyTest.java @@ -27,6 +27,7 @@ import org.eclipse.microprofile.reactive.messaging.Channel; import org.eclipse.microprofile.reactive.messaging.Incoming; import org.eclipse.microprofile.reactive.messaging.Message; +import org.eclipse.microprofile.reactive.messaging.Metadata; import org.eclipse.microprofile.reactive.messaging.Outgoing; import org.junit.jupiter.api.Test; @@ -468,13 +469,14 @@ void testReplyOffsetResetEarliest() { .with("reply.auto.offset.reset", "earliest"), RequestReplyProducer.class); for (int i = 0; i < 10; i++) { - app.requestReply().request(i).subscribe().with(replies::add); + app.requestReply().request(Message.of(i, Metadata.of(OutgoingKafkaRecordMetadata.builder() + .withKey("" + i).build()))).subscribe().with(r -> replies.add(r.getPayload())); } await().untilAsserted(() -> assertThat(replies).hasSize(10)); - assertThat(replies).containsExactly("0", "1", "2", "3", "4", "5", "6", "7", "8", "9"); + assertThat(replies).containsExactlyInAnyOrder("0", "1", "2", "3", "4", "5", "6", "7", "8", "9"); assertThat(companion.consumeStrings().fromTopics(replyTopic, 10).awaitCompletion()) - .extracting(ConsumerRecord::value).containsExactly("0", "1", "2", "3", "4", "5", "6", "7", "8", "9"); + .extracting(ConsumerRecord::value).containsExactlyInAnyOrder("0", "1", "2", "3", "4", "5", "6", "7", "8", "9"); } @Test