-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS SQS #1117
Comments
I would love to collaborate with this implementation but I have a few theoretical doubts when it comes to backpressure and implementing the incoming connector. First a high level overview of how SQS works. SQS offers a long polling mechanism (max 20 secs), can return up to a maximum of 10 messages per poll/batch and AWS offers an async SDK. So a very simple implementation for a PublisherBuilder I came up with is to poll indefefinitely and create a multi with each of the items per batch. Note that the async SQS client from the SDK returns a completion stage:
However, given that this implementation would poll indefinitely, would not this defeat the purpose of backpressure? Or will this only poll as long as downstream requests for more items? Finally, thank you very much for your time. |
I don't now SQS, but Mutiny will only retry when there is request. So, I believe the back pressure will be managed. |
@tcerdaITBA I'd like to contribute to this as well. Have you made any progress on your side? |
hello, anyone still interested on working on this? |
|
|
anyone interested on working on adding SQS support ?XD |
Hello |
Sure, a contribution would be more than welcome. |
i would like to help |
@tcerdaITBA are you still interested? It seems you did some work towards and now it seems there are ppl willing to support. |
Hi I started with an implementation: I think I have no issues with the actual implementation. But there are some concepts which confuses me a little bit. So maybe you can help me to bring it into the right direction. But first the progress. Progress: |
Questions:
Thank you for some help. |
@cescoffier can we get support with code review? It seems more people want to contribute. |
Sure, @ozangunalp abd I would be happy to review the code |
Hello @cescoffier @ozangunalp . Sorry to ping again but maybe review was forgotten by accident :) |
@adampoplawski where is the PR? |
Hello @cescoffier |
I did not create a pr yet, because I did not write tests etc. yet. As @adampoplawski mentioned I wrote some questions. I needed to chill a little bit. I was working to much. I will try to finish what I started asap. I have some freetime soon-ish |
Thanks for this. |
I created the pr. It is not done yet, but maybe review, help etc. is easier to achieve: |
Are we planning to merge it anytime soon? Eagerly awaiting this.... |
Nope. Feel free to help. There is still much to do. |
@cescoffier @ozangunalp There is new PR. |
Add support for AWS SQS: https://aws.amazon.com/sqs/
The text was updated successfully, but these errors were encountered: