JUnit 5

[t1]

I think it's time to go to JUnit 5. We can stay backward compatible with JUnit Vintage.

I'll suggest a PR.

This is a prerequisite for smallrye/smallrye-graphql#100

[kenfinnigan]

I don't think Arquillian works with JUnit5 at present, which is a blocker as we need it for the TCKs.

Maybe one solution is to define both JUnit versions, as if I recall they're different artifacts

[t1]

Arquillian seems to work just fine with JUnit 5 Vintage. At least smallrye/smallrye-graphql#216 builds just fine after you have this PR in your local maven repo.

[kenfinnigan]

Good to know.

Before we change the parent I think it would be good to verify another project with a SNAPSHOT of the parent

[t1]

@kenfinnigan : I can do that. What project would you suggest?

[kenfinnigan]

Maybe smallrye-fault-tolerance?

[t1]

It works just fine with smallrye-fault-tolerance.

But truth be told, I've also tried it with smallrye-reactive-messaging as it's even more complex... and it fails with exceptions that I don't understand :-( I guess they'd have to manage their JUnit 4 dependency themselves until they find a workaround or a fix. But they already use JUnit 5 in some parts, so it's just a switch from managing the future to managing the past ;-)

[t1]

@kenfinnigan : ... or would you prefer two managed dependencies? If yes, we can either add version.junit5 in addition to the existing version.junit (easier upgrade for existing projects) or a new version.junit4 and update the exiting version.junit (more future proof).

[t1]

We would like to use JUnit 5 in smallrye-graphql. Can I help in any way?

[kenfinnigan]

Initially it's probably best to have both JUnit versions and dependencies in the pom.

[t1]

@radcortez just added it. Thanks!

I have a minor comment on that. Then we can close this.