-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JUnit 5 #133
Comments
I don't think Arquillian works with JUnit5 at present, which is a blocker as we need it for the TCKs. Maybe one solution is to define both JUnit versions, as if I recall they're different artifacts |
Arquillian seems to work just fine with JUnit 5 Vintage. At least smallrye/smallrye-graphql#216 builds just fine after you have this PR in your local maven repo. |
Good to know. Before we change the parent I think it would be good to verify another project with a SNAPSHOT of the parent |
@kenfinnigan : I can do that. What project would you suggest? |
Maybe smallrye-fault-tolerance? |
It works just fine with But truth be told, I've also tried it with |
@kenfinnigan : ... or would you prefer two managed dependencies? If yes, we can either add |
We would like to use JUnit 5 in smallrye-graphql. Can I help in any way? |
Initially it's probably best to have both JUnit versions and dependencies in the pom. |
@radcortez just added it. Thanks! I have a minor comment on that. Then we can close this. |
I think it's time to go to JUnit 5. We can stay backward compatible with JUnit Vintage.
I'll suggest a PR.
This is a prerequisite for smallrye/smallrye-graphql#100
The text was updated successfully, but these errors were encountered: