Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display slide import errors in client #1816

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

AlbertBrand
Copy link
Contributor

While debugging some other issue, it appeared that error messages were consumed in some scenarios. This PR adds error logging to the console when the cached slide import fails, making it easier for others to debug their issues.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 825e71d
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66bb647d86ffbc000889420b
😎 Deploy Preview https://deploy-preview-1816--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Aug 13, 2024

commit: 825e71d

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1816

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1816

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1816

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1816

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1816

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1816

Open in Stackblitz

Copy link
Member

@KermanX KermanX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/slidev/node/virtual/slides.ts Outdated Show resolved Hide resolved
Co-authored-by: _Kerman <kermanx@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants