Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hmr experience #1708

Merged
merged 14 commits into from
Jul 17, 2024
Merged

fix: hmr experience #1708

merged 14 commits into from
Jul 17, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Jun 28, 2024

  1. fix: Circular dependency caused flash during HMR
  2. perf: Update preload strategy. Previously, it depended on QuickOverview, now its logic is written in SlidesShow.
  3. fix: no longer pre-mount QuickOverview (i.e. v-if="showOverview" instead of v-show="showOverview")
  4. fix: the last "Preview Next" in presenter mode disappears
  5. fix: clicksContext.onMounted/onUnmounted should be called correctly.

Blocked by vuejs/core#11248

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 12067cf
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/6697ceb838bee4000891de49
😎 Deploy Preview https://deploy-preview-1708--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX KermanX marked this pull request as draft June 28, 2024 02:51
@KermanX KermanX marked this pull request as ready for review June 28, 2024 02:58
@KermanX KermanX marked this pull request as draft June 28, 2024 03:54
@KermanX KermanX changed the title fix: circular dependency caused flash during hmr fix: hmr experience Jun 28, 2024
@KermanX KermanX marked this pull request as ready for review July 17, 2024 13:58
@antfu
Copy link
Member

antfu commented Jul 17, 2024

Do we need to wait until the next Vue patch? I see, it's released in .32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants