Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use untun instead of localtunnel (#1225) #1286

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Feb 12, 2024

fix #1225

There is a security vulnerability related to the axios dependency of localtunnel, but there isn't a newer version of localtunnel.

This PR use untun to replace localtunnel.

image

(edited after antfu's comment)

(I don't know why the e2e tests failed. It seems not relevant to this PR)

@antfu
Copy link
Member

antfu commented Feb 12, 2024

I think instead, we could switch to https://unjs.io/packages/untun

@KermanX KermanX marked this pull request as draft February 12, 2024 11:37
@KermanX KermanX changed the title feat: not install localtunnel by default (#1225) feat: use untun instead of localtunnel (#1225) Feb 13, 2024
@KermanX KermanX marked this pull request as ready for review February 13, 2024 06:14
@antfu antfu merged commit d6bb539 into slidevjs:main Feb 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios Cross-Site Request Forgery Vulnerability
2 participants