Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier plugin/parser #1261

Closed
antfu opened this issue Jan 31, 2024 · 5 comments
Closed

Prettier plugin/parser #1261

antfu opened this issue Jan 31, 2024 · 5 comments
Labels
enhancement New feature or request pr welcome

Comments

@antfu
Copy link
Member

antfu commented Jan 31, 2024

Introduce a Prettier plugin to format Slidev's extension well

Related #854

@KermanX
Copy link
Member

KermanX commented Feb 1, 2024

I wrote one in https://github.com/KermanX/prettier-plugin-slidev. (Not published to npm)

I don't know whether it is better to make it a package in the monorepo or a separate repository in the slidevjs org.

TODO:

Known issues:

  1. In the Latex code block, the line highlighting part will be moved to the next line by Prettier like this:
$$
{1|3|all}
\begin{array}{c}
...
\end{array}
$$

I think it is hard to fix. Thankfully, this doesn't break the line highlighting functionality.

@KermanX
Copy link
Member

KermanX commented Feb 11, 2024

@antfu I think https://github.com/KermanX/prettier-plugin-slidev is ready for a release. Should the repository be transferred to the slidev organization, and then publish a release? (I can't do it myself because I don't have the permission)

@antfu
Copy link
Member Author

antfu commented Feb 11, 2024

Looks promising! Just invited to join the team!

Up to you if want to transfer the repo to this org, or want to migrate it inside this monorepo :)

@KermanX
Copy link
Member

KermanX commented Feb 11, 2024

I have transferred it to https://github.com/slidevjs/prettier-plugin, and published it as prettier-plugin-slidev@1.0.0. (Invited @antfu to the package)

@KermanX KermanX closed this as completed Feb 11, 2024
@antfu
Copy link
Member Author

antfu commented Feb 11, 2024

Awesome, thanks! Check your Discord btw :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants