diff --git a/src/tests/shell-test/shell-test.c b/src/tests/shell-test/shell-test.c index 49d07f780..359175734 100644 --- a/src/tests/shell-test/shell-test.c +++ b/src/tests/shell-test/shell-test.c @@ -59,7 +59,7 @@ void TestOutputToFile(void) size_t size; int32 filepos; int32 status; - osal_id_t fd; + osal_id_t fd = OS_OBJECT_ID_UNDEFINED; OS_mkfs(NULL, "/ramdev0", "RAM", 512, 20); OS_mount("/ramdev0", "/drive0"); diff --git a/src/tests/symbol-api-test/symbol-api-test.c b/src/tests/symbol-api-test/symbol-api-test.c index 43905b814..6e331bbb3 100644 --- a/src/tests/symbol-api-test/symbol-api-test.c +++ b/src/tests/symbol-api-test/symbol-api-test.c @@ -31,7 +31,7 @@ void TestSymbolApi(void) { int32 status; - cpuaddr SymAddress; + cpuaddr SymAddress = NULL; /* Make the file system */ status = OS_mkfs(0, "/ramdev0", "RAM", 512, 2048); diff --git a/src/tests/timer-test/timer-test.c b/src/tests/timer-test/timer-test.c index 356a661c3..3f37dd8ac 100644 --- a/src/tests/timer-test/timer-test.c +++ b/src/tests/timer-test/timer-test.c @@ -57,7 +57,7 @@ uint32 timer_idlookup[OS_MAX_TIMERS]; */ void test_func(osal_id_t timer_id) { - osal_index_t idx; + osal_index_t idx = OSAL_INDEX_C(0); OS_ConvertToArrayIndex(timer_id, &idx); timer_counter[timer_idlookup[idx]]++; } @@ -114,10 +114,12 @@ void TimerTestTask(void) int i = 0; int32 TimerStatus[NUMBER_OF_TIMERS]; - osal_index_t TableId; + osal_index_t TableId = OSAL_INDEX_C(0); osal_id_t TimerID[NUMBER_OF_TIMERS]; char TimerName[NUMBER_OF_TIMERS][20] = {"TIMER1", "TIMER2", "TIMER3", "TIMER4", "TIMER5"}; - uint32 ClockAccuracy; + uint32 ClockAccuracy = 0; + + memset(TimerID, 0, sizeof(TimerID)); for (i = 0; i < NUMBER_OF_TIMERS && i < OS_MAX_TIMERS; i++) { diff --git a/src/unit-tests/oscore-test/ut_oscore_binsem_test.c b/src/unit-tests/oscore-test/ut_oscore_binsem_test.c index 9bd5f1585..83f5f49d7 100644 --- a/src/unit-tests/oscore-test/ut_oscore_binsem_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_binsem_test.c @@ -70,6 +70,8 @@ void UT_os_bin_sem_create_test() char long_sem_name[UT_OS_NAME_BUFF_SIZE]; osal_id_t sem_ids[OS_MAX_BIN_SEMAPHORES + 1]; + memset(sem_ids, 0, sizeof(sem_ids)); + /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemCreate(NULL, "BinSem1", 1, 0), OS_INVALID_POINTER); @@ -128,7 +130,7 @@ void UT_os_bin_sem_create_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_delete_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemDelete(UT_OBJID_INCORRECT), OS_ERR_INVALID_ID); @@ -152,7 +154,7 @@ void UT_os_bin_sem_delete_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_flush_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemFlush(UT_OBJID_INCORRECT), OS_ERR_INVALID_ID); @@ -177,7 +179,7 @@ void UT_os_bin_sem_flush_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_give_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemGive(UT_OBJID_INCORRECT), OS_ERR_INVALID_ID); @@ -203,7 +205,7 @@ void UT_os_bin_sem_give_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_take_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemTake(UT_OBJID_INCORRECT), OS_ERR_INVALID_ID); @@ -228,7 +230,7 @@ void UT_os_bin_sem_take_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_timed_wait_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ UT_RETVAL(OS_BinSemTimedWait(UT_OBJID_INCORRECT, 1000), OS_ERR_INVALID_ID); @@ -261,7 +263,7 @@ void UT_os_bin_sem_timed_wait_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_get_id_by_name_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; char long_sem_name[UT_OS_NAME_BUFF_SIZE]; /*-----------------------------------------------------*/ @@ -297,7 +299,7 @@ void UT_os_bin_sem_get_id_by_name_test() **--------------------------------------------------------------------------------*/ void UT_os_bin_sem_get_info_test() { - osal_id_t bin_sem_id; + osal_id_t bin_sem_id = OS_OBJECT_ID_UNDEFINED; OS_bin_sem_prop_t bin_sem_prop; /*-----------------------------------------------------*/ diff --git a/src/unit-tests/oscore-test/ut_oscore_countsem_test.c b/src/unit-tests/oscore-test/ut_oscore_countsem_test.c index 39c4bef9c..70138304c 100644 --- a/src/unit-tests/oscore-test/ut_oscore_countsem_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_countsem_test.c @@ -70,6 +70,8 @@ void UT_os_count_sem_create_test() char sem_name[UT_OS_NAME_BUFF_SIZE]; char long_sem_name[UT_OS_NAME_BUFF_SIZE]; + memset(count_sem_ids, 0, sizeof(count_sem_ids)); + /*-----------------------------------------------------*/ /* #1 Null-pointer-arg-1 */ @@ -155,7 +157,7 @@ void UT_os_count_sem_create_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_delete_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -184,7 +186,7 @@ void UT_os_count_sem_delete_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_give_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -215,7 +217,7 @@ void UT_os_count_sem_give_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_take_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -245,7 +247,7 @@ void UT_os_count_sem_take_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_timed_wait_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -289,7 +291,7 @@ void UT_os_count_sem_timed_wait_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_get_id_by_name_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; char long_sem_name[UT_OS_NAME_BUFF_SIZE]; /*-----------------------------------------------------*/ @@ -336,7 +338,7 @@ void UT_os_count_sem_get_id_by_name_test() **--------------------------------------------------------------------------------*/ void UT_os_count_sem_get_info_test() { - osal_id_t count_sem_id; + osal_id_t count_sem_id = OS_OBJECT_ID_UNDEFINED; OS_count_sem_prop_t count_sem_prop; /*-----------------------------------------------------*/ diff --git a/src/unit-tests/oscore-test/ut_oscore_misc_test.c b/src/unit-tests/oscore-test/ut_oscore_misc_test.c index de5092f0c..dcfd7e792 100644 --- a/src/unit-tests/oscore-test/ut_oscore_misc_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_misc_test.c @@ -86,12 +86,13 @@ *--------------------------------------------------------------------------------*/ void UT_os_apiinit_test() { - osal_id_t qId; - osal_blockcount_t qDepth = OSAL_BLOCKCOUNT_C(10); - size_t qSize = OSAL_SIZE_C(4); - uint32 qFlags = 0; - osal_id_t semIds[3]; - uint32 semInitValue = 1, semOptions = 0; + osal_id_t qId = OS_OBJECT_ID_UNDEFINED; + osal_blockcount_t qDepth = OSAL_BLOCKCOUNT_C(10); + size_t qSize = OSAL_SIZE_C(4); + uint32 qFlags = 0; + osal_id_t semIds[3] = {OS_OBJECT_ID_UNDEFINED, OS_OBJECT_ID_UNDEFINED, OS_OBJECT_ID_UNDEFINED}; + uint32 semInitValue = 1; + uint32 semOptions = 0; /*-----------------------------------------------------*/ /* #1 Init-not-call-first */ @@ -245,6 +246,8 @@ void UT_os_getlocaltime_test() OS_time_t time_struct; int32 i = 0; + memset(&time_struct, 0, sizeof(time_struct)); + /*-----------------------------------------------------*/ /* API not implemented */ @@ -309,6 +312,8 @@ void UT_os_setlocaltime_test() OS_time_t time_struct; int32 i = 0; + memset(&time_struct, 0, sizeof(time_struct)); + /*-----------------------------------------------------*/ /* API not implemented */ @@ -386,6 +391,8 @@ void UT_os_geterrorname_test(void) { os_err_name_t errNames[4]; + memset(errNames, 0, sizeof(errNames)); + /*-----------------------------------------------------*/ /* #1 Null-pointer-arg */ diff --git a/src/unit-tests/oscore-test/ut_oscore_mutex_test.c b/src/unit-tests/oscore-test/ut_oscore_mutex_test.c index 3c4b8e593..447c29589 100644 --- a/src/unit-tests/oscore-test/ut_oscore_mutex_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_mutex_test.c @@ -66,8 +66,8 @@ void UT_os_mut_sem_create_test() { int i; - osal_id_t mut_sem_id; - osal_id_t mut_sem_id2; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; + osal_id_t mut_sem_id2 = OS_OBJECT_ID_UNDEFINED; char sem_name[UT_OS_NAME_BUFF_SIZE]; char long_sem_name[UT_OS_NAME_BUFF_SIZE]; @@ -141,7 +141,7 @@ void UT_os_mut_sem_create_test() **--------------------------------------------------------------------------------*/ void UT_os_mut_sem_delete_test() { - osal_id_t mut_sem_id; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -169,7 +169,7 @@ void UT_os_mut_sem_delete_test() **--------------------------------------------------------------------------------*/ void UT_os_mut_sem_give_test() { - osal_id_t mut_sem_id; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -202,7 +202,7 @@ void UT_os_mut_sem_give_test() **--------------------------------------------------------------------------------*/ void UT_os_mut_sem_take_test() { - osal_id_t mut_sem_id; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -233,7 +233,7 @@ void UT_os_mut_sem_take_test() **--------------------------------------------------------------------------------*/ void UT_os_mut_sem_get_id_by_name_test() { - osal_id_t mut_sem_id; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; char long_sem_name[UT_OS_NAME_BUFF_SIZE]; /*-----------------------------------------------------*/ @@ -278,7 +278,7 @@ void UT_os_mut_sem_get_id_by_name_test() **--------------------------------------------------------------------------------*/ void UT_os_mut_sem_get_info_test() { - osal_id_t mut_sem_id; + osal_id_t mut_sem_id = OS_OBJECT_ID_UNDEFINED; OS_mut_sem_prop_t mut_sem_prop; /*-----------------------------------------------------*/ diff --git a/src/unit-tests/oscore-test/ut_oscore_queue_test.c b/src/unit-tests/oscore-test/ut_oscore_queue_test.c index 47c82f2e8..81cad4185 100644 --- a/src/unit-tests/oscore-test/ut_oscore_queue_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_queue_test.c @@ -70,8 +70,8 @@ void UT_os_queue_create_test() { int i = 0; - osal_id_t queue_id; - osal_id_t queue_id2; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; + osal_id_t queue_id2 = OS_OBJECT_ID_UNDEFINED; char queue_name[UT_OS_NAME_BUFF_SIZE]; char long_queue_name[UT_OS_NAME_BUFF_SIZE]; @@ -153,7 +153,7 @@ void UT_os_queue_create_test() **--------------------------------------------------------------------------------*/ void UT_os_queue_delete_test() { - osal_id_t queue_id; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Invalid-ID-arg */ @@ -183,7 +183,7 @@ void UT_os_queue_delete_test() **--------------------------------------------------------------------------------*/ void UT_os_queue_get_test() { - osal_id_t queue_id; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; uint32 queue_data_out; uint32 queue_data_in; size_t size_copied; @@ -298,7 +298,7 @@ void UT_os_queue_get_test() **--------------------------------------------------------------------------------*/ void UT_os_queue_put_test() { - osal_id_t queue_id; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; uint32 queue_data_out = 0; int i; @@ -364,7 +364,7 @@ void UT_os_queue_put_test() **--------------------------------------------------------------------------------*/ void UT_os_queue_get_id_by_name_test() { - osal_id_t queue_id; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; char long_queue_name[UT_OS_NAME_BUFF_SIZE]; /*-----------------------------------------------------*/ @@ -410,7 +410,7 @@ void UT_os_queue_get_id_by_name_test() **--------------------------------------------------------------------------------*/ void UT_os_queue_get_info_test() { - osal_id_t queue_id; + osal_id_t queue_id = OS_OBJECT_ID_UNDEFINED; OS_queue_prop_t queue_prop; /*-----------------------------------------------------*/ diff --git a/src/unit-tests/oscore-test/ut_oscore_task_test.c b/src/unit-tests/oscore-test/ut_oscore_task_test.c index 4a4ee8588..71f5369ce 100644 --- a/src/unit-tests/oscore-test/ut_oscore_task_test.c +++ b/src/unit-tests/oscore-test/ut_oscore_task_test.c @@ -396,6 +396,10 @@ void UT_os_task_delay_test() OS_time_t after_time; int64 elapsed; + /* Initialize to avoid static analysis warnings */ + memset(&before_time, 0, sizeof(before_time)); + memset(&after_time, 0, sizeof(after_time)); + /* * Note, if running under a VM/hypervisor, the real time clock may not * be very precise, depending on its implementation. Therefore the allowed diff --git a/src/unit-tests/osfile-test/ut_osfile_dirio_test.c b/src/unit-tests/osfile-test/ut_osfile_dirio_test.c index 4f0ef3db2..17c452a05 100644 --- a/src/unit-tests/osfile-test/ut_osfile_dirio_test.c +++ b/src/unit-tests/osfile-test/ut_osfile_dirio_test.c @@ -124,7 +124,7 @@ void UT_os_read_n_sort_dirs(osal_id_t); **--------------------------------------------------------------------------------*/ void UT_os_makedir_test() { - osal_id_t fileDesc; + osal_id_t fileDesc = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Null-pointer-arg */ @@ -205,7 +205,7 @@ void UT_os_makedir_test() **--------------------------------------------------------------------------------*/ void UT_os_opendir_test() { - osal_id_t dirh; + osal_id_t dirh = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Null-pointer-arg */ @@ -278,7 +278,7 @@ void UT_os_opendir_test() **--------------------------------------------------------------------------------*/ void UT_os_closedir_test() { - osal_id_t dirh; + osal_id_t dirh = OS_OBJECT_ID_UNDEFINED; os_dirent_t dirEntry; UT_RETVAL(OS_DirectoryClose(UT_OBJID_INCORRECT), OS_ERR_INVALID_ID); @@ -543,7 +543,7 @@ void UT_os_rewinddir_test() **--------------------------------------------------------------------------------*/ void UT_os_removedir_test() { - osal_id_t fileDesc; + osal_id_t fileDesc = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* #1 Null-pointer-arg */ @@ -600,6 +600,7 @@ void UT_os_read_n_sort_dirs(osal_id_t dirh) const char *Name; memset(g_dirItems, 0, sizeof(g_dirItems)); + memset(&dirEntry, 0, sizeof(dirEntry)); NumMatched = 0; NumEntries = 0; diff --git a/src/unit-tests/osfile-test/ut_osfile_fileio_test.c b/src/unit-tests/osfile-test/ut_osfile_fileio_test.c index 1ecd51251..e11baed56 100644 --- a/src/unit-tests/osfile-test/ut_osfile_fileio_test.c +++ b/src/unit-tests/osfile-test/ut_osfile_fileio_test.c @@ -878,9 +878,13 @@ void UT_os_chmodfile_test() **--------------------------------------------------------------------------------*/ void UT_os_statfile_test() { - os_fstat_t fstats1, fstats2; + os_fstat_t fstats1; + os_fstat_t fstats2; size_t expected_len; + memset(&fstats1, 0, sizeof(fstats1)); + memset(&fstats2, 0, sizeof(fstats2)); + /*-----------------------------------------------------*/ /* #1 Null-pointer-arg */ UT_RETVAL(OS_stat(NULL, &fstats1), OS_INVALID_POINTER); diff --git a/src/unit-tests/osloader-test/ut_osloader_module_test.c b/src/unit-tests/osloader-test/ut_osloader_module_test.c index 52dcb9001..3115be5c6 100644 --- a/src/unit-tests/osloader-test/ut_osloader_module_test.c +++ b/src/unit-tests/osloader-test/ut_osloader_module_test.c @@ -66,8 +66,8 @@ void UT_os_module_load_test() { int i; - osal_id_t module_id; - osal_id_t module_id2; + osal_id_t module_id = OS_OBJECT_ID_UNDEFINED; + osal_id_t module_id2 = OS_OBJECT_ID_UNDEFINED; char module_name[UT_OS_NAME_BUFF_SIZE]; char module_file_name[UT_OS_PATH_BUFF_SIZE]; @@ -169,7 +169,7 @@ void UT_os_module_load_test() **--------------------------------------------------------------------------------*/ void UT_os_module_unload_test() { - osal_id_t module_id; + osal_id_t module_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* API Not implemented */ @@ -208,7 +208,7 @@ void UT_os_module_unload_test() **--------------------------------------------------------------------------------*/ void UT_os_module_info_test() { - osal_id_t module_id; + osal_id_t module_id = OS_OBJECT_ID_UNDEFINED; OS_module_prop_t module_info; /*-----------------------------------------------------*/ diff --git a/src/unit-tests/osloader-test/ut_osloader_symtable_test.c b/src/unit-tests/osloader-test/ut_osloader_symtable_test.c index d0710ba78..4f1b6f72a 100644 --- a/src/unit-tests/osloader-test/ut_osloader_symtable_test.c +++ b/src/unit-tests/osloader-test/ut_osloader_symtable_test.c @@ -73,7 +73,7 @@ void UT_os_symbol_lookup_test() { cpuaddr symbol_addr; - osal_id_t module_id; + osal_id_t module_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* API Not implemented */ @@ -137,7 +137,7 @@ void UT_os_symbol_lookup_test() void UT_os_module_symbol_lookup_test() { cpuaddr symbol_addr; - osal_id_t module_id; + osal_id_t module_id = OS_OBJECT_ID_UNDEFINED; /*-----------------------------------------------------*/ /* API Not implemented */