Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TruffleRuby in CI #1079

Merged
merged 3 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
- '3.2'
- '3.3'
- jruby-9.4
- truffleruby

steps:
- uses: actions/checkout@v4
Expand All @@ -28,5 +29,13 @@ jobs:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true

- run: |
bundle exec rake
- name: Run tests
run: bundle exec rake
if: matrix.ruby-version != 'truffleruby'

# Run only `rake spec` on truffleruby, because just `rake` runs `rubocop spec cucumber`.
# There is no value to rerun rubocop here.
# cucumber fails because it uses an old childprocess which depends on fork.
- name: Run specs (truffleruby)
run: bundle exec rake spec
PragTob marked this conversation as resolved.
Show resolved Hide resolved
if: matrix.ruby-version == 'truffleruby'
15 changes: 11 additions & 4 deletions .github/workflows/unstable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
ruby-version:
- ruby-head
- jruby-head
- truffleruby-head

steps:
- uses: actions/checkout@v4
Expand All @@ -25,8 +26,14 @@ jobs:
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true
continue-on-error: ${{ (matrix.ruby-version == 'ruby-head') || (matrix.ruby-version == 'jruby-head') }}

- run: |
bundle exec rake
continue-on-error: ${{ (matrix.ruby-version == 'ruby-head') || (matrix.ruby-version == 'jruby-head') }}
- name: Run tests
run: bundle exec rake
if: matrix.ruby-version != 'truffleruby-head'

# Run only `rake spec` on truffleruby, because just `rake` runs `rubocop spec cucumber`.
# There is no value to rerun rubocop here.
# cucumber fails because it uses an old childprocess which depends on fork.
- name: Run specs (truffleruby)
run: bundle exec rake spec
if: matrix.ruby-version == 'truffleruby-head'
eregon marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions spec/return_codes_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
end

it "prints a message to STDERR" do
# https://github.com/oracle/truffleruby/issues/3535
skip "fails on truffleruby" if RUBY_ENGINE == "truffleruby" && command.include?("testunit_bad.rb")
eregon marked this conversation as resolved.
Show resolved Hide resolved
expect(@stderr).to match(/stopped.+SimpleCov.+previous.+error/i)
end
end
Expand Down