Fix for Coverage.running? and add TruffleRuby in CI #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
force-pushed
the
coverage_running_and_truffleruby_ci
branch
from
04770f9
to
0714596
Compare
eregon
force-pushed
the
coverage_running_and_truffleruby_ci
branch
from
0714596
to
87ca614
Compare
eregon
commented
Feb 21, 2023
| if: matrix.ruby != 'truffleruby' | ||
|
|
||
| - name: Run specs (truffleruby) | ||
| run: bundle exec rake spec |
There was a problem hiding this comment.
I'm not running cucumber on TruffleRuby because that doesn't work due to old cucumber using old aruba using childprocess which is not really maintained currently (enkessler/childprocess#172).
|
CI is green. |
|
We should decrease bus-factor on such repositories. @amatsuda, sorry, are you available? You seem to be a member of @simplecov-ruby |
|
Replaced by #1079. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix of #1043 + adding TruffleRuby CI. Fixes #1044.
There is one test failing (
testunit_bad.rb), I'm not sure why yet, but it seems valuable to run all other tests on TruffleRuby until that's figured out.I also simplified both workflows, especially
.github/workflows/unstable.ymlwas a lot more complicated than necessary.