-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage analysis stops before all tests have finished when using the gem minitest-optional_retry #673
Comments
@spjsschl, you might be interested in this. |
Interesting. I'm almost certain this has to do with the fact that minitest runs in an It's also possible it's Spring related. I haven't looked too carefully at the https://github.com/michel-zimmer/rails-simplecov-minitest-optional_retry-mcve app yet. Thanks for that. |
Might potentially be fixed with #756 |
@michel-zimmer do you want to re-test this? I hope it's fixed with #756 which I'll release soon but is already on master. |
Hi @PragTob, thanks for your patience. Though I'm not developing with Ruby anymore and therefore don't depend on this problem being solved and also I won't be of much help either: I've got the mvce barely updated and running let alone debugging the problem properly ;) Br, Michel |
Well thanks :) Might take a look but it's always hard to see in these things how it happens. As mentioned before, I suspect some |
I think this is an issue with bundler's autorequire "feature"... either tack on |
When requiring the gem minitest-optional_retry the coverage analysis stops before all tests have finished.
Output from before adding the gem:
bin/rails test Running via Spring preloader in process 16635 Run options: --seed 9134 # Running: ..... Finished in 0.119671s, 41.7812 runs/s, 58.4937 assertions/s. 5 runs, 7 assertions, 0 failures, 0 errors, 0 skips Coverage report generated for MiniTest to [...]/rails-simplecov-minitest-optional_retry-mcve/coverage. 25 / 29 LOC (86.21%) covered.
Output from after adding the gem:
bin/rails test Running via Spring preloader in process 16735 Coverage report generated for MiniTest to [...]/rails-simplecov-minitest-optional_retry-mcve/coverage. 0 / 44 LOC (0.0%) covered. Run options: --seed 56425 # Running: ..... Finished in 0.111954s, 44.6613 runs/s, 62.5258 assertions/s. 5 runs, 7 assertions, 0 failures, 0 errors, 0 skips
Everything is on most recent release:
This file contains everything the gem actually does:
(Taken from https://github.com/appfolio/minitest-optional_retry/blob/22490f82088cf13b2bf1abee8ebb3fc8050bd543/lib/minitest/optional_retry.rb)
I've create a mcve to be sure. It's source code can be found here (direct link to commits view). It consists of creating a Rails app, scaffolding something for testing, adding SimpleCov and then adding them gem.
The text was updated successfully, but these errors were encountered: