Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert encoding replace #95

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Revert encoding replace #95

merged 2 commits into from
Feb 23, 2020

Conversation

PragTob
Copy link
Collaborator

@PragTob PragTob commented Feb 22, 2020

This reverts commit 2608b9d.

Replaced by: simplecov-ruby/simplecov#866
As suggested by: #91 (comment)
Should be safe to revert as apparently ruby itself doesn't work
when the encoding isn't declared properly so should be good.

For files that aren't required by ruby but tracked we added a
test case with broken encoding (in simplecov main) but it still
seems to work. So this complexity is likely not needed anymore.

This reverts commit 2608b9d.

Replaced by: simplecov-ruby/simplecov#866
As suggested by: #91 (comment)
Should be safe to revert as apparently ruby itself doesn't work
when the encoding isn't declared properly so should be good.

For files that aren't required by ruby but tracked we added a
test case with broken encoding (in simplecov main) but it still
seems to work.  So this complexity is likely not needed anymore.
@PragTob
Copy link
Collaborator Author

PragTob commented Feb 22, 2020

Probably can't/shouldn't revert due to jruby/jruby#6093

@PragTob PragTob merged commit 001fb52 into master Feb 23, 2020
@PragTob PragTob deleted the revert-encoding-replace branch February 23, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant