Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a separate, unified slashing cache for use in broadcast_validation #5017

Closed
realbigsean opened this issue Dec 18, 2023 · 1 comment
Closed

Create a separate, unified slashing cache for use in broadcast_validation #5017

realbigsean opened this issue Dec 18, 2023 · 1 comment
Labels
deneb enhancement New feature or request HTTP-API

Comments

@realbigsean
Copy link
Member

realbigsean commented Dec 18, 2023 •
edited
Loading

Description

#4995 revealed that the re-use of gossip caches for understanding "slashability" of a block no longer works post-deneb. The gossip conditions might be changed in the future so that it does work again, but I don't think it's worth banking on. Tracking "slashability" here is needed generally so support broadcast_validation=consensus_and_equivocation.

Moving the slashing logic from the observed_block_producers and observed_blob_sidecars to a single new slashing cache can help simplify what we have currently. It will also allow us to more easily incorporate blocks seen via RPC: #4725 (comment)
@michaelsproul michaelsproul added HTTP-API enhancement New feature or request labels Dec 19, 2023
@realbigsean realbigsean mentioned this issue Jan 3, 2024
Merged
@realbigsean
Copy link
Member Author

implemented in #5033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deneb enhancement New feature or request HTTP-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @realbigsean