Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change blob storage structure in database #4099

Closed
Tracked by #3989
ethDreamer opened this issue Mar 16, 2023 · 1 comment
Closed
Tracked by #3989

Change blob storage structure in database #4099

ethDreamer opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels

Comments

@ethDreamer
Copy link
Member

ethDreamer commented Mar 16, 2023

Blob decoupling is motivating the following changes to the p2p layer:

BeaconBlockAndBlobsSidecarByRoot -> BlobSidecarsByRoot
BlobsSidecarsByRange -> BlobSidecarsByRange

For the BlobSidecarsByRoot, the request is changing from List[Root, MAX_REQUEST_BLOCKS] to List[BlobIdentifier, MAX_REQUEST_BLOB_SIDECARS] and for both methods the response is changing to List[BlobSidecar, MAX_REQUEST_BLOB_SIDECARS].

This is requires changes to how blobs are stored in the database. The database and attester caches currently stores blobs as:

root -> BlobsSidecar

when they need to be stored as:

root -> Vec<BlobSidecar>

will probably need a new BlobStreamer object (similar to BeaconBlockStreamer) to pre-process the BlobSidecarsByRoot requests and minimize database lookups.

@ethDreamer
Copy link
Member Author

fixed by #4104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants