Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tigera/eks-policy-only): use sighup registry for images #55

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

lzecca78
Copy link
Contributor

Hi everyone 👋 ,
during a cluster upgrade, we've discovered that we are not specifying the registry.
This PR should fix the issue #54

Added support for customizing the installation registry awareness for
each resources created by the operator.

Co-authored-by: Federico Antoniazzi <federico.antoniazzi@sighup.io>
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change 👇

katalog/tigera/eks-policy-only/kustomization.yaml Outdated Show resolved Hide resolved
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Nitpick: please try to use "Conventional Commits" in the future to keep things homogeneous with the rest of the code base.

@ralgozino ralgozino changed the title Introduced registry patch for Installation crd fix(tigera): use sighup registry for images Mar 14, 2023
@nutellinoit nutellinoit self-requested a review March 14, 2023 15:47
@ralgozino ralgozino changed the title fix(tigera): use sighup registry for images fix(tigera/eks-policy-only): use sighup registry for images Mar 14, 2023
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks-policy-only Installation crd doesn't specify the image of the subresources that the operator will create
3 participants