Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command exit code to output if it fails #342

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Add command exit code to output if it fails #342

merged 7 commits into from
Oct 25, 2020

Conversation

KaindlJulian
Copy link
Contributor

Implements the first point from #341. The exit code is included in the error message that is already being printed.

e.g.

$ hyperfine false
Benchmark #1: false
Error: Command terminated with non-zero exit code: 1. Use the '-i'/'--ignore-failure' option if you want to ignore this. Alternatively, use the '--show-output' option to debug what went wrong.",

Implements the first point from #341. The exit code is  included in
the warning that is already being printed.
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

Could you please add an entry to the "unreleased" section in CHANGELOG.md? The format for entries is:

- Description what has been changed, see #123 (@user)

where #123 links to the bug ticket and/or the PR and user is your username.

src/hyperfine/benchmark.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/hyperfine/benchmark.rs Outdated Show resolved Hide resolved
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@sharkdp sharkdp merged commit c05d7f9 into sharkdp:master Oct 25, 2020
@sharkdp
Copy link
Owner

sharkdp commented Oct 17, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants