Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why relogin after browser close? #2102

Open
rioradio opened this issue Jun 15, 2024 · 4 comments
Open

Question: Why relogin after browser close? #2102

rioradio opened this issue Jun 15, 2024 · 4 comments

Comments

@rioradio
Copy link

Question

Why do I need to login again after closing the browser?

Semaphore UI v2.9.112 (Docker)

Related to

No response

@rioradio
Copy link
Author

rioradio commented Jun 18, 2024

As I understand it, when logging in, the server sets cookies without specifying the expiration date (Expires).
0016962221542254

The browser set cookie as session cookie.
0016975921585958

And session cookies are deleted when the browser is closed.
Therefore, you just need to add expiration dates to the cookies.

@fiftin
Copy link
Collaborator

fiftin commented Jun 19, 2024

Hi @rioradio
yes, you are right. What the right session life expectancy? @tboerger what do you think?

@rioradio
Copy link
Author

Hi @fiftin
I think the best thing is to allow this value to be configured through the config. For myself, I would use a cookie expiration time of 1 year

@tboerger
Copy link
Collaborator

I don't have strong feelings about that. For me it's fine to kill the session if the browser is closed.

Adding an option for that which will give an empty value like now and can be set to anything sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants