Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for Linux #2

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

yaynstuff
Copy link
Contributor

Compilation on linux fails with:

dullahan_host.cpp:33:51: error: conversion from ‘long int’ to ‘CefRefPtr’ {aka ‘scoped_refptr’} is ambiguous
33 | return CefExecuteProcess(main_args, NULL, NULL);
| ^

Changing NULL to nullptr allows compilation to proceed.

@callumprentice
Copy link

Looks good to me. Thank you.

@bennettgoble
Copy link
Member

@callumprentice is it okay to merge these changes into main or do we need to wait until the changes are integrated into a viewer that is promoted to default release?

@nat-goodspeed
Copy link
Contributor

Callum and I are discussing, and would like to surface this question at our upcoming meeting.

@nat-goodspeed nat-goodspeed merged commit c185cd5 into secondlife:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants