Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mysys2 instead of cygwin #36

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Use mysys2 instead of cygwin #36

merged 1 commit into from
Apr 8, 2024

Conversation

bennettgoble
Copy link
Member

@bennettgoble bennettgoble commented Apr 8, 2024

Github runners come with mysys2 installed (This is what is used when you call shell: bash on a windows runner.) Using mysys2 means we can avoid the rather costly cygwin install time during builds.

Example run: https://github.com/secondlife/3p-zlib-ng/actions/runs/8606156593

Screenshot 2024-04-08 133118

@bennettgoble bennettgoble force-pushed the signal/mysys2 branch 4 times, most recently from a7ef81d to 3abf2f3 Compare April 8, 2024 20:12
@bennettgoble bennettgoble changed the title Add option to use mysys2 instead of cygwin Use mysys2 instead of cygwin Apr 8, 2024
@bennettgoble bennettgoble added the enhancement New feature or request label Apr 8, 2024
Github runners come with mysys2 installed (This is what is used when you
call `shell: bash` on a windows runner.) Using mysys2 means we can avoid
the rather costly cygwin install costs during builds.
Copy link

@brad-linden brad-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bennettgoble bennettgoble merged commit f28ed3a into main Apr 8, 2024
3 checks passed
@bennettgoble bennettgoble deleted the signal/mysys2 branch April 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants