Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to requests in release notes script #2067

Closed
rwedge opened this issue Jun 13, 2024 · 0 comments · Fixed by #2109
Closed

Add timeouts to requests in release notes script #2067

rwedge opened this issue Jun 13, 2024 · 0 comments · Fixed by #2109
Assignees
@gsheni
Labels
internal The issue doesn't change the API or functionality
Milestone
1.15.0

Comments

@rwedge
Copy link
Contributor

rwedge commented Jun 13, 2024

Background

Recent code analysis job discovered several new issues (see #2066), mostly focused on requests made by the release notes script.

Expected

Address the newly surfaced issues by adding a timeout to the requests calls in the script (release_note_generator.py).
@rwedge rwedge added the internal The issue doesn't change the API or functionality label Jun 13, 2024
@gsheni gsheni self-assigned this Jul 3, 2024
@gsheni gsheni mentioned this issue Jul 3, 2024
Merged
@amontanez24 amontanez24 added this to the 1.15.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsheni gsheni

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

Add timeouts to requests in release notes script sdv-dev/SDV
3 participants
@rwedge @amontanez24 @gsheni