Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header to log.csv file #2046

Closed
amontanez24 opened this issue Jun 4, 2024 · 0 comments · Fixed by #2054
Closed

Add header to log.csv file #2046

amontanez24 opened this issue Jun 4, 2024 · 0 comments · Fixed by #2054
Assignees
@lajohn4747
Labels
feature request Request for a new feature
Milestone
1.14.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

As an engineer debugging logs, it would be helpful to know what each column meant.

Expected behavior

The log.csv file should have headers (a label for each column). Currently it doesn't.

Additional context

Headers seem to be specified but for some reason aren't working

SDV/sdv/logging/logger.py

Lines 16 to 18 in 29cf341

headers = [
'LEVEL', 'EVENT', 'TIMESTAMP', 'SYNTHESIZER CLASS NAME', 'SYNTHESIZER ID',
'TOTAL NUMBER OF TABLES', 'TOTAL NUMBER OF ROWS', 'TOTAL NUMBER OF COLUMNS'

@amontanez24 amontanez24 added the feature request Request for a new feature label Jun 4, 2024
@lajohn4747 lajohn4747 self-assigned this Jun 11, 2024
@lajohn4747 lajohn4747 added this to the 1.13.2 milestone Jun 11, 2024
@lajohn4747 lajohn4747 mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajohn4747 lajohn4747

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

Ensure header gets written first time when opening file sdv-dev/SDV
2 participants
@amontanez24 @lajohn4747