You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While this approach is ok, it is not consistent with other parts of our product and may not be future-proof.
Expected behavior
Update the handler.read function (for both CSV and Excel) to just read and return the data. Do not create or return metadata in this function.
Create a new function called create_metadata (for both CSV and Excel). This function should take as input a dictionary of DataFrames. It should output a MultiTableMetadata object.
In the future, we would like to allow flags in create_metadata in order to control whether inference should be done. But this is out of scope for the current issue.
# EXAMPLE only: out of scopemetadata=handler.create_metadata(
infer_sdtypes=True,
infer_primary_keys=False,
infer_foreign_keys=True)
The text was updated successfully, but these errors were encountered:
Problem Description
The local file handlers (for CSV and Excel) currently return both the metadata and data in one go.
While this approach is ok, it is not consistent with other parts of our product and may not be future-proof.
Expected behavior
handler.read
function (for both CSV and Excel) to just read and return the data. Do not create or return metadata in this function.create_metadata
(for both CSV and Excel). This function should take as input a dictionary of DataFrames. It should output aMultiTableMetadata
object.Below is the updated user journey:
Additional context
In the future, we would like to allow flags in create_metadata in order to control whether inference should be done. But this is out of scope for the current issue.
The text was updated successfully, but these errors were encountered: