Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDV compatible with the latest SDMetrics #1687

Closed
npatki opened this issue Nov 22, 2023 · 0 comments · Fixed by #1697
Closed

Make SDV compatible with the latest SDMetrics #1687

npatki opened this issue Nov 22, 2023 · 0 comments · Fixed by #1697
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Nov 22, 2023

Problem Description

The upcoming SDMetrics release will include a new and improved Diagnostic Report, performing basic validity checks to pinpoint any areas of concern.

As soon as this newest SDMetrics release is out (0.13.0), the SDV should immediately be updated to include the latest version. Otherwise, it may cause some confusion since the existing Diagnostic Report is a bit different.

Expected behavior

Although there are no overall changes to the API, users should observe that the diagnostic now produces different results from running the latest report. This applies to both the single and multi table run_diagnostic method.

sdv.evaluation.single_table import run_diagnostic

diagnostic_report = run_diangnostic(
    real_data=real_data,
    synthetic_data=synthetic_data,
    metadata=metadata)

The new properties (Data Validity, Structure, etc.) should be visible after updating to the latest SDMetrics.

Generating report ...
(1/2) Evaluating Data Validity: : 100%|██████████| 17/17 [00:00<00:00, 374.65it/s]
(2/2) Evaluating Data Structure: : 100%|██████████| 1/1 [00:00<00:00, 104.39it/s]

Overall Score: 100.0%

Properties:
- Data Validity: 100.0%
- Data Structure: 100.0%
@npatki npatki added the feature request Request for a new feature label Nov 22, 2023
@amontanez24 amontanez24 added this to the 1.8.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants