Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty tables to be fitted using fit_processed_data #1524

Closed
amontanez24 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1526
Closed

Allow empty tables to be fitted using fit_processed_data #1524

amontanez24 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1526
Assignees
@fealho
Labels
feature request Request for a new feature
Milestone
1.3.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it would be great of multi-table synthesizers were able to fit and sample even when child tables don't have statistical columns as that is a common database structure.

Expected behavior

  • fit_processed_data should not crash if the dataframe passed is empty.
  • If the data is empty, it should:
    • set _fitted to True
    • set _fitted_date
    • set _fitted_sdv_version
  • If the data is not empty, it should only set those parameters if _fit runs successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Allow empty tables to be fitted using fit_processed_data sdv-dev/SDV
2 participants
@amontanez24 @fealho