Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIM checks #3258

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add SIM checks #3258

merged 1 commit into from
Sep 24, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 24, 2024

See #1241

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 79.24528% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.96%. Comparing base (8b2088d) to head (1b1fbc9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/plotting/_tools/__init__.py 44.44% 5 Missing ⚠️
src/scanpy/tools/_sim.py 58.33% 5 Missing ⚠️
src/scanpy/plotting/_anndata.py 81.25% 3 Missing ⚠️
src/scanpy/plotting/_baseplot_class.py 71.42% 2 Missing ⚠️
src/scanpy/_utils/compute/is_constant.py 0.00% 1 Missing ⚠️
src/scanpy/external/pl.py 50.00% 1 Missing ⚠️
src/scanpy/plotting/_tools/scatterplots.py 75.00% 1 Missing ⚠️
src/scanpy/preprocessing/_simple.py 66.66% 1 Missing ⚠️
src/scanpy/tools/_ingest.py 75.00% 1 Missing ⚠️
src/scanpy/tools/_paga.py 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
+ Coverage   76.85%   76.96%   +0.11%     
==========================================
  Files         109      109              
  Lines       12554    12469      -85     
==========================================
- Hits         9648     9597      -51     
+ Misses       2906     2872      -34     
Flag Coverage Δ
76.96% <79.24%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/_settings.py 90.20% <100.00%> (ø)
src/scanpy/_utils/__init__.py 75.51% <100.00%> (+0.26%) ⬆️
src/scanpy/datasets/_datasets.py 100.00% <ø> (ø)
src/scanpy/datasets/_ebi_expression_atlas.py 93.97% <100.00%> (+1.03%) ⬆️
src/scanpy/get/get.py 92.06% <100.00%> (-0.17%) ⬇️
src/scanpy/neighbors/__init__.py 81.11% <100.00%> (-0.15%) ⬇️
src/scanpy/plotting/_tools/paga.py 68.47% <100.00%> (ø)
src/scanpy/plotting/_utils.py 56.64% <100.00%> (ø)
src/scanpy/preprocessing/_combat.py 91.47% <100.00%> (+0.63%) ⬆️
src/scanpy/preprocessing/_deprecated/__init__.py 90.47% <100.00%> (ø)
... and 22 more

@flying-sheep flying-sheep merged commit d998742 into main Sep 24, 2024
17 of 20 checks passed
@flying-sheep flying-sheep deleted the check-sim branch September 24, 2024 17:19
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Sep 24, 2024
flying-sheep added a commit that referenced this pull request Sep 24, 2024
Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant