From f2a769b28d91a81cdf2a593434693ca71f81c8e6 Mon Sep 17 00:00:00 2001 From: zhenfei Date: Mon, 31 Jul 2023 13:00:37 -0400 Subject: [PATCH 1/2] fix-tob-scroll-21 --- halo2_proofs/src/helpers.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/halo2_proofs/src/helpers.rs b/halo2_proofs/src/helpers.rs index f58ec9b100..e8521aa7ff 100644 --- a/halo2_proofs/src/helpers.rs +++ b/halo2_proofs/src/helpers.rs @@ -48,6 +48,10 @@ pub fn field_to_bn(f: &F) -> BigUint { /// Input a big integer `bn`, compute a field element `f` /// such that `f == bn % F::MODULUS`. +/// Require: +/// - bn is less than 512 bits. +/// Return: +/// - bn mod F::MODULUS when bn > F::MODULUS pub fn bn_to_field(bn: &BigUint) -> F { let mut buf = bn.to_bytes_le(); buf.resize(64, 0u8); From cf0fe5bb45776fb8a4cccd3cf723bfe20252abc5 Mon Sep 17 00:00:00 2001 From: zhenfei Date: Thu, 14 Sep 2023 19:29:34 -0400 Subject: [PATCH 2/2] expose param field for re-randomization --- halo2_proofs/src/poly/kzg/commitment.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/halo2_proofs/src/poly/kzg/commitment.rs b/halo2_proofs/src/poly/kzg/commitment.rs index 27d188aa5c..08665667b3 100644 --- a/halo2_proofs/src/poly/kzg/commitment.rs +++ b/halo2_proofs/src/poly/kzg/commitment.rs @@ -21,12 +21,12 @@ use super::msm::MSMKZG; /// These are the public parameters for the polynomial commitment scheme. #[derive(Debug, Clone)] pub struct ParamsKZG { - pub(crate) k: u32, + pub k: u32, pub n: u64, - pub(crate) g: Vec, + pub g: Vec, pub g_lagrange: Vec, - pub(crate) g2: E::G2Affine, - pub(crate) s_g2: E::G2Affine, + pub g2: E::G2Affine, + pub s_g2: E::G2Affine, } /// Umbrella commitment scheme construction for all KZG variants