From e56d03f0328e6a050d8e60d319377fc6b253522c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20P=C3=A9rez?= <37264926+CPerezz@users.noreply.github.com> Date: Wed, 3 May 2023 16:25:08 +0200 Subject: [PATCH] fix: Fix serialization for VerifyingKey (#178) Now the value returned when the number of selectors is a multiple of 8 is correct. Resolves: #175 --- halo2_proofs/src/plonk.rs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/halo2_proofs/src/plonk.rs b/halo2_proofs/src/plonk.rs index c718e4a97f..62c684ceb4 100644 --- a/halo2_proofs/src/plonk.rs +++ b/halo2_proofs/src/plonk.rs @@ -168,14 +168,13 @@ where fn bytes_length(&self) -> usize { 8 + (self.fixed_commitments.len() * C::default().to_bytes().as_ref().len()) + self.permutation.bytes_length() - /* - + self.selectors.len() - * (self - .selectors - .get(0) - .map(|selector| selector.len() / 8 + 1) - .unwrap_or(0)) - */ + // scroll/halo2: we don’t need to store + // + self.selectors.len() + // * (self + // .selectors + // .get(0) + // .map(|selector| (selector.len() + 7) / 8) + // .unwrap_or(0)) } fn from_parts(