Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol import from JSON fails if there is no top-level plugin_data key/value #242

Open
cfobel opened this issue Aug 24, 2017 · 0 comments
Open

Protocol import from JSON fails if there is no top-level plugin_data key/value #242

cfobel opened this issue Aug 24, 2017 · 0 comments
Assignees
@cfobel
Labels
cat:Protocols component:App type:Bug

Comments

@cfobel
Copy link
Contributor

cfobel commented Aug 24, 2017

The procotol_from_dict function unintentionally fails if a JSON protocol does not contain any protocol-level plugin data.

Proposed fix

Only try to load protocol-level plugin data if the corresponding key is present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfobel cfobel

Labels
cat:Protocols component:App type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfobel