Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify exploring zarr and importing wkw #7474

Closed
fm3 opened this issue Dec 5, 2023 · 0 comments · Fixed by #7697
Closed

Unify exploring zarr and importing wkw #7474

fm3 opened this issue Dec 5, 2023 · 0 comments · Fixed by #7697

Comments

@fm3
Copy link
Member

fm3 commented Dec 5, 2023

The settings page calls the datastore route GET /datasets/:organizationName/:dataSetName (DataSourceController.suggestDatasourceJson) which traverses the files and makes automatic suggestions for the datasource-properties.json. This works only for WKW and was originally designed also as an import step (when dataset creators didn’t write their own datasource-properties.jsons).

#7475 skips this step for Zarr and presents a warning instead of a ton of errors (that were there before because the data didn’t match the WKW format).

We should decide if we want to implement this also for other dataformats like zarr. It could reuse the explore code that is used for remote datasets. However, the suggestions might be imperfect there, as the original datasource-properties.jsons might contain more relevant information that can be inferred from just the zarr array files.

We might also want to discontinue this feature altogether, as zarr becomes more common and datasets are usually either explored remotely (uses the explore code), created via the libs (should already have good datasource-properties.json) or uploaded using the web upload (has its own version of this feature as of #7397).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants