Community package requirements: sanity tests

[gotmax23]

Summary

(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 1.4.1 of community.sap_libs, corresponding to the 1.4.1 tag in this repo, fails one or more of the required sanity tests.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.

---

Sanity tests

The following tests were run using ansible-test version 2.16.1:

• ansible-doc
• compile
• validate-modules
• yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

💡 NOTE:

Check the [explain] links below for more information about each test and how to fix failures.
See Sanity Tests: Ignores in the dev guide if, after reading the test-specific documentation, you still believe an error is a false positive.

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

plugins/modules/sap_company.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_control_exec.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_hdbsql.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_pyrfc.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_snote.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_system_facts.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_task_list_execute.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sap_user.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
plugins/modules/sapcar_extract.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module

Issue Type

Bug Report

Component Name

n/a

Ansible Version

n/a

community.sap_libs Version

n/a

Configuration

n/a

OS / Environment

n/a

Steps to Reproduce

n/a

Expected Results

n/a

Actual Results

n/a

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[rhmk]

I think now it is time to create proper Apache-2.0 header in all files in. all repos to avoid licensing misinterpretations

[rainerleber]

The modules contains an Apache header, the issue is that it is not GPLv3 :-). I have excluded the validation check for the license but because of a reason I don't unterstand this exclusion is ignored.

[rainerleber]

fixed in new version

[gotmax23]

Sounds good. Thanks!

[gotmax23]

Please also make sure that you're running these tests in your CI to catch any future issues. Thanks!