Jinja variable 'config' is undefined

[bluemalkin]

Hi,

I ran a state apply on this formula, docker dependencies got updated:

          ID: docker-package-dependencies
    Function: pkg.installed
      Result: True
     Comment: The following packages were installed/updated: python3-pip
              The following packages were already installed: apt-transport-https, python3-apt

However it errors out with:

----------
          ID: docker-config
    Function: file.managed
        Name: /etc/default/docker
      Result: False
     Comment: Unable to manage file: Jinja variable 'config' is undefined
     Started: 05:20:04.208177
    Duration: 149.465 ms
     Changes:
----------
          ID: docker-service
    Function: service.running
        Name: docker
      Result: False
     Comment: One or more requisite failed: docker.install.docker-config
     Started: 05:20:04.359830
    Duration: 0.022 ms
     Changes:

Looking at the source code I cannot see anywhere where config is defined.

[myii]

@bluemalkin Just a quick response for the time being. This is almost definitely related to the changes introduced in #216. You'll also get a summary of the uses of config from this search:

• https://github.com/saltstack-formulas/docker-formula/search?utf8=%E2%9C%93&q=config&type=

It has been around in defaults.yaml for a while, it's just the usage probably requires a default value after #216. Or you could try setting a default value of [] in your pillar.

[noelmcloughlin]

I replicated on Ubuntu.

          ID: docker-config
    Function: file.managed
        Name: /etc/default/docker
      Result: False
     Comment: Unable to manage file: Jinja variable 'config' is undefined

[myii]

@noelmcloughlin Thanks for confirming the regression. Does the fix I suggested in #216 (comment) work for you?

[noelmcloughlin]

Thanks for confirming the regression. Does the fix I suggested in #216 (comment) work for you?

Both of the following work-

(1)

 58     - config:
 59       - config: {{ docker.config | d([]) }}

(2)

 58     - config:
 59       - config: {{ docker.config | json }}

This file is ignored by systemd btw #74

[myii]

@noelmcloughlin Shall we go with | json then? Would you like to do it or shall I? This fix is needed pretty quickly, to prevent other failures out there.

[noelmcloughlin]

Wait there is something wrong. If you notice my comment above accidently used config parameter instead of context parameter. Restesting both context: parameter does not work.

Comment: Context must be formed as a dict

I tried a few variations of `{{ docker.config | json}}' and '{{docker.config | d([]) }}' without success.

[noelmcloughlin]

58 - config:

The example above should have read ...

58 - context:

[noelmcloughlin]

Got it. Raised PR #226 @myii @bluemalkin

[myii]

@noelmcloughlin If you look at the example I gave earlier, it doesn't start with the leading hyphen -- that leads to it being evaluated as a list.

[noelmcloughlin]

Yes, I raised the fixed PR.

[bluemalkin]

Can confirm the fix works. Many thanks for the quick turnaround !