Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ipykernel to 6.6.0, make debugpy optional #33020

Closed
tornaria opened this issue Dec 13, 2021 · 19 comments
Closed

update ipykernel to 6.6.0, make debugpy optional #33020

tornaria opened this issue Dec 13, 2021 · 19 comments

Comments

@tornaria
Copy link
Contributor

This new standard package contains precompiled binaries, which are dynamically linked to a particular libc.

In particular this causes some problems building sage with the musl libc.

AFAICT, this was added in #31280 just because it was a new dependency for ipykernel.

OTOH, debugpy was made optional in ipython/ipykernel#767 and this is included in ipykernel 6.4.0 and up (current version 6.6.0).

Is it possible to

  • either upgrade ipykernel or add the patch to make debugpy optional;
  • and then either remove or make optional debugpy in sagemath
    before 9.5, please?

Depends on #32930

CC: @mkoeppe

Component: packages: standard

Author: Gonzalo Tornaría

Branch/Commit: 715d1ea

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33020

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 13, 2021

comment:1

It is strange that ipykernel still declares the dependency on debugpy as an install_requires (https://github.com/ipython/ipykernel/blob/main/setup.py#L66).

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 13, 2021

comment:2

I'd say for Sage 9.5, let's add PR 767 as a patch, patch out the install_requires (otherwise there will be a warning when installing the ipykernel package.), and move the dependency on debugpy from ipykernel to jupyterlab

@tornaria
Copy link
Contributor Author

comment:3

Note arch pkg for debugpy removes all these precompiled libs and compiles the one for linux 64 bit (see https://github.com/archlinux/svntogit-community/blob/packages/python-debugpy/trunk/PKGBUILD).

It doesn't even seem difficult, as it is a single file. However, making sure this works for all supported architectures may be nontrivial, but otoh I expect the current package doesn't really work in all supported architectures anyway.

@tornaria
Copy link
Contributor Author

Commit: 15cf50e

@tornaria
Copy link
Contributor Author

New commits:

15cf50eupdate ipykernel and make debugpy optional

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/33020

@tornaria
Copy link
Contributor Author

comment:5

That commit works for me, it includes updating ipykernel to 6.6.0 and patching out setup.py and pyproject.toml.

If you prefer to stay at 6.3.1 and add PR 767 as a patch, that'd be easy to do (I was already testing this when I saw your comment).

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

Dependencies: #32930

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

Changed branch from u/tornaria/33020 to u/mkoeppe/33020

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:8

I've put this on top of #32930


Last 10 new commits:

6347f98build/pkgs/prompt_toolkit: Update to 3.0.22
28e535dbuild/pkgs/widgetsnbextension: Update to 3.5.2
63078acbuild/pkgs/terminado: Update to 0.12.1
22de5dcbuild/pkgs/notebook: Update to 6.4.6
a0fe18bbuild/pkgs/nbclient: Update to 0.5.4
ef3fc7fbuild/pkgs/jupyter_client: Update to 7.1.0
a593bc9build/pkgs/jupyter_core: Update to 4.9.1
66c16b1build/pkgs/importlib_metadata: Update to 4.8.2
cdfde89Merge #32930
af1a6b0update ipykernel and make debugpy optional

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

Changed commit from 15cf50e to af1a6b0

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

Author: Gonzalo Tornaría

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Changed commit from af1a6b0 to 715277c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

715277cupdate ipykernel and make debugpy optional

@mkoeppe mkoeppe changed the title debugpy: contains precompiled binaries update ipykernel to 6.6.0, make debugpy optional Dec 18, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

715d1eabuild/pkgs/ipykernel/checksums.ini: Use files.pythonhosted.org URL

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Changed commit from 715277c to 715d1ea

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:13

The pypi.io URL didn't seem to work, so I changed it to one that works.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Dec 23, 2021

Changed branch from u/mkoeppe/33020 to 715d1ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants