From 0af160fd7cb33d6dcb07702d4786e62c01f37140 Mon Sep 17 00:00:00 2001 From: Gonzalo <456459+grzuy@users.noreply.github.com> Date: Mon, 20 Nov 2023 13:33:24 -0300 Subject: [PATCH 1/3] fixes cargo.toml local path dep? --- rustler_mix/lib/rustler/compiler/config.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rustler_mix/lib/rustler/compiler/config.ex b/rustler_mix/lib/rustler/compiler/config.ex index dc508fe0..34981919 100644 --- a/rustler_mix/lib/rustler/compiler/config.ex +++ b/rustler_mix/lib/rustler/compiler/config.ex @@ -139,7 +139,7 @@ defmodule Rustler.Compiler.Config do |> MapSet.new(& &1["name"]) |> MapSet.union(visited) - gather_local_crates(packages, as_specs ++ rest, paths, visited) + gather_local_crates(packages, Enum.filter(as_specs ++ rest, & &1), paths, visited) end defp get_spec(packages, name) do From bc5097815b9828d8b18bdbda9ff2842cbbaf38b4 Mon Sep 17 00:00:00 2001 From: Gonzalo <456459+grzuy@users.noreply.github.com> Date: Mon, 20 Nov 2023 14:07:36 -0300 Subject: [PATCH 2/3] only filter as_specs --- rustler_mix/lib/rustler/compiler/config.ex | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rustler_mix/lib/rustler/compiler/config.ex b/rustler_mix/lib/rustler/compiler/config.ex index 34981919..f8948f07 100644 --- a/rustler_mix/lib/rustler/compiler/config.ex +++ b/rustler_mix/lib/rustler/compiler/config.ex @@ -132,14 +132,17 @@ defmodule Rustler.Compiler.Config do paths = Enum.map(local_deps, & &1["path"]) ++ paths_acc - as_specs = Enum.map(local_deps, &get_spec(packages, &1["name"])) + as_specs = + local_deps + |> Enum.map(&get_spec(packages, &1["name"])) + |> Enum.filter(& &1) visited = local_deps |> MapSet.new(& &1["name"]) |> MapSet.union(visited) - gather_local_crates(packages, Enum.filter(as_specs ++ rest, & &1), paths, visited) + gather_local_crates(packages, as_specs ++ rest, paths, visited) end defp get_spec(packages, name) do From 1e142477dead5504db570db03f5a774163f819cf Mon Sep 17 00:00:00 2001 From: Gonzalo <456459+grzuy@users.noreply.github.com> Date: Mon, 20 Nov 2023 14:10:20 -0300 Subject: [PATCH 3/3] prefer reject is_nil --- rustler_mix/lib/rustler/compiler/config.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rustler_mix/lib/rustler/compiler/config.ex b/rustler_mix/lib/rustler/compiler/config.ex index f8948f07..2ff908b3 100644 --- a/rustler_mix/lib/rustler/compiler/config.ex +++ b/rustler_mix/lib/rustler/compiler/config.ex @@ -135,7 +135,7 @@ defmodule Rustler.Compiler.Config do as_specs = local_deps |> Enum.map(&get_spec(packages, &1["name"])) - |> Enum.filter(& &1) + |> Enum.reject(&is_nil/1) visited = local_deps