Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

One lock per file #2

Open
nrc opened this issue Oct 19, 2016 · 2 comments
Open

One lock per file #2

nrc opened this issue Oct 19, 2016 · 2 comments

Comments

@nrc
Copy link
Member

nrc commented Oct 19, 2016

Currently we have one lock for the whole VFS which is not very efficient.
@matklad
Copy link
Contributor

matklad commented Nov 21, 2016

Perhaps just change Mutex to RwLock? I don't expect there to a lot of parallelism: modification requests should be serialized anyway, and I think most editors (IDEA for sure) already serialize edition operations on their side.

@nrc
Copy link
Member Author

nrc commented May 29, 2017

We no longer hold the mega-lock for any file-system operations. So this is not so urgent any more. Should probably still change to RWLock.

@Xanewok Xanewok mentioned this issue Feb 25, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrc @matklad