Optimize normalize_flat_keys #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krzysiek1507
commented
May 23, 2020
•
krzysiek1507
commented
I18n::Backend::Flatten.normalize_flat_keys :en, :home, [:country, :county, :second], '|'
Calculating -------------------------------------
original 1.060k memsize ( 0.000 retained)
21.000 objects ( 0.000 retained)
7.000 strings ( 0.000 retained)
patch 652.000 memsize ( 0.000 retained)
14.000 objects ( 0.000 retained)
7.000 strings ( 0.000 retained)
Comparison:
patch: 652 allocated
original: 1060 allocated - 1.63x more
Warming up --------------------------------------
original 15.765k i/100ms
patch 18.043k i/100ms
Calculating -------------------------------------
original 156.733k (± 3.5%) i/s - 788.250k in 5.036161s
patch 180.959k (± 1.9%) i/s - 920.193k in 5.086948s
Comparison:
patch: 180959.0 i/s
original: 156733.1 i/s - 1.15x (± 0.00) slower
krzysiek1507
force-pushed
the
feature/optimize-normalize_flat_keys
branch
from
5b04f13
to
4031429
Compare
radar
approved these changes
Jun 4, 2020
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.