From 382898e02c4cf19745ec603a4baf7b4577b9b517 Mon Sep 17 00:00:00 2001 From: Max Kerp Date: Tue, 17 Nov 2020 12:22:44 +0100 Subject: [PATCH 1/3] Update UPGRADING.md I'm currently upgrading a fairly big rails app I did not write myself which uses grape. Since I unfortunately never used grape before (I want to though :wink:), I was in unknown territory and it took me quite I while to figure out that grape added support for rack >= 2.1.0 first on 1.3.0. First thing I did when running into [https://github.com/ruby-grape/grape/issues/1966](this error) was checking the Upgrade.md file for any signs of rack incompatibility, but I did not find any. I wish I did, since it took me a few hours to find the mentioned issue. (I really have to up my google-fu, I know :see_no_evil:) But for any poor soul in the future, who is just as bad as googling as I am, it might be helpful to mention this in the Upgrade guide :) --- UPGRADING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UPGRADING.md b/UPGRADING.md index e5b6947fa2..1fe30db687 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -189,6 +189,8 @@ end ### Upgrading to >= 1.3.0 +#### Added Rack 2.1.0 support + #### Ruby After adding dry-types, Ruby 2.4 or newer is required. From 4fa475086f3f98f1abd78242bbb082729c30b269 Mon Sep 17 00:00:00 2001 From: Max Kerp Date: Tue, 4 May 2021 17:09:26 +0200 Subject: [PATCH 2/3] Update UPGRADING.md Support for `rack >= 2.1.0` starts with `grape 1.3.0` --- UPGRADING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPGRADING.md b/UPGRADING.md index 1fe30db687..51443d396f 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -189,7 +189,7 @@ end ### Upgrading to >= 1.3.0 -#### Added Rack 2.1.0 support +You will need to upgrade to this version if you depend on `rack >= 2.1.0` #### Ruby From 2a610e0e8eb6741d3cb2fd9e71bf03ae4e35432d Mon Sep 17 00:00:00 2001 From: Max Kerp Date: Wed, 5 May 2021 10:48:39 +0200 Subject: [PATCH 3/3] Update UPGRADING.md Well, I missed a period. --- UPGRADING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPGRADING.md b/UPGRADING.md index 51443d396f..e13a2e8ca6 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -189,7 +189,7 @@ end ### Upgrading to >= 1.3.0 -You will need to upgrade to this version if you depend on `rack >= 2.1.0` +You will need to upgrade to this version if you depend on `rack >= 2.1.0`. #### Ruby