From 903576f39385e1240632baaa400e19cbca429fd3 Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 19 Aug 2024 16:32:37 +0900 Subject: [PATCH] Fix some rubocop offenses This PR fixes some rubocop offenses ``` tasks/cut_release.rake:41:21: W: [Corrected] Lint/ImplicitStringConcatenation: Combine '\0' and "## #{version} (#{Time.now.strftime('%F')})\n\n" into a single string literal, rather than using implicit string concatenation. Or, if they were intended to be separate method arguments, separate them with a comma. '\0' "## #{version} (#{Time.now.strftime('%F')})\n\n") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tasks/cut_release.rake:41:21: C: [Corrected] Style/StringConcatenation: Prefer string interpolation to string concatenation. '\0' + "## #{version} (#{Time.now.strftime('%F')})\n\n") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` --- tasks/cut_release.rake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/cut_release.rake b/tasks/cut_release.rake index 7a90d7d..65844b6 100644 --- a/tasks/cut_release.rake +++ b/tasks/cut_release.rake @@ -38,7 +38,7 @@ namespace :cut_release do def add_header_to_changelog(version) update_file('CHANGELOG.md') do |changelog| changelog.sub("## Edge (Unreleased)\n\n", - '\0' "## #{version} (#{Time.now.strftime('%F')})\n\n") + "\\0## #{version} (#{Time.now.strftime('%F')})\n\n") end end