Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip specs correctly if DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH set to true #2393

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Sep 22, 2024

Skip specs correctly if DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH set to true

This commit skips failing specs correctly if DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH set to true

Follow up #2389

$ export DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH="true"
$ bundle exec rspec ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb
==> Loading config from ENV or use default
==> Running specs with ruby version 3.3.5
/home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
==> Effective ActiveRecord version 7.1.4
**

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value from TIMESTAMP columns
     # No reason given
     # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:49

  2) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value with fractional seconds from TIMESTAMP columns
     # No reason given
     # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:63

Finished in 0.00178 seconds (files took 0.53574 seconds to load)
2 examples, 0 failures, 2 pending

$

@yahonda yahonda force-pushed the skip_them branch 2 times, most recently from 274cd42 to 1e422b8 Compare September 22, 2024 11:37
…TCH` set to true

This commit skips failing specs correctly if `DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH` set to true

Follow up rsim#2389

```ruby
$
export DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH="true"
bundle exec rspec ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb
==> Loading config from ENV or use default
==> Running specs with ruby version 3.3.5
/home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
==> Effective ActiveRecord version 7.1.4
**

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value from TIMESTAMP columns
     # No reason given
     # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:49

  2) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value with fractional seconds from TIMESTAMP columns
     # No reason given
     # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:63

Finished in 0.00178 seconds (files took 0.53574 seconds to load)
2 examples, 0 failures, 2 pending

$
```
@yahonda yahonda changed the title Skip specs Skip specs correctly if DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH set to true Sep 22, 2024
@yahonda yahonda marked this pull request as ready for review September 22, 2024 11:38
@yahonda yahonda merged commit bb97edc into rsim:master Sep 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant